Skip to content

Preserve edge topology when exporting PLY meshes #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humanbeingZ wants to merge 1 commit into
base: devel
Choose a base branch
from
+5 −3
Open

Preserve edge topology when exporting PLY meshes #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/meshlab/dialogs/save_mesh_attributes_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,10 @@ bool SaveMeshAttributesDialog::shouldBeChecked(int bit, int /*capabilityBits*/,

void SaveMeshAttributesDialog::updateMask()
{
int newmask = 0;
// Edge connectivity is topology, not an optional per-element attribute, and
// therefore has no checkbox in this dialog. Preserve it when the exporter
// includes it in its default mask.
int newmask = defaultBits & vcg::tri::io::Mask::IOM_EDGEINDEX;

if( ui->check_iom_vertflags->isChecked() ) { newmask |= vcg::tri::io::Mask::IOM_VERTFLAGS;}
if( ui->check_iom_vertcolor->isChecked() ) { newmask |= vcg::tri::io::Mask::IOM_VERTCOLOR;}
Expand Down Expand Up @@ -319,4 +322,3 @@ void SaveMeshAttributesDialog::on_textureQualitySpinBox_valueChanged(int arg1)
ui->textureQualitySpinBox->setSuffix("");
}
}

2 changes: 1 addition & 1 deletion src/meshlabplugins/io_base/baseio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ void BaseMeshIOPlugin::saveProject(
void BaseMeshIOPlugin::exportMaskCapability(const QString &format, int &capability, int &defaultBits) const
{
if (format.toUpper() == tr("PLY")) {
capability = tri::io::ExporterPLY<CMeshO>::GetExportMaskCapability();
capability = tri::io::ExporterPLY<CMeshO>::GetExportMaskCapability() | tri::io::Mask::IOM_EDGEINDEX;
// For the default bits of the ply format disable flags and normals that usually are not useful.
defaultBits = capability;
defaultBits &= (~tri::io::Mask::IOM_FLAGS);
Expand Down
Loading