Add ShaderTest1 experiment with data-driven config panel#200
Open
cnotv wants to merge 2 commits into
Open
Conversation
Extracts the view's setup config into a co-located config.ts and registers a reactive shader config + schema with the existing viewConfig store (same pattern as GrassGenerator), so the Config panel auto-generates a Frequency slider bound to the uFrequency uniform. New properties can be added by extending the config/schema objects without further plumbing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for cnotv-generative-art ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShaderTest1) with an animated ripple plane, plus aThreejsToolsShadertemplateGrassGenerator), exposing a liveFrequencyslider bound to the shader'suFrequencyuniformKey Changes
src/views/Experiments/ShaderTest1/— new view, vertex/fragment shaders, and a co-locatedconfig.tsholding the reactive config + schema for the Config panelregisterViewConfig/unregisterViewConfig+setViewPanels({ showConfig: true })wire the view intouseViewConfigStore, so the Config tab auto-generates a "Shader → Frequency" slider from the schema; new properties can be added by extendingshaderTest1Config/shaderTest1Schema, no further plumbing neededuFrequency, so the slider updates the wave instantly without reinitializing the scenesrc/views/Templates/ThreejsToolsShader.vue— new templateTest Plan
pnpm type-checkpassespnpm test:unitpasses (1322 tests)