feat(agent-forge): add 401 authentication error handling with tests - #13
Merged
suwhang-cisco merged 5 commits intoNov 10, 2025
Merged
Conversation
Implemented comprehensive 401 error handling for OpenID token authentication: - Modified authentication to only handle 401 errors (removed 403 handling) - Added OpenID token expiration detection with JWT decoding - Implemented configurable auto-reload on token expiry (autoReloadOnTokenExpiry) - Added 5-second countdown toast before page reload - Added session expired toast with manual reload button for API 401 errors - Created 35 unit tests with 100% pass rate covering: * Token expiration validation * 401 error detection (excluding 403) * Toast notifications and user interactions * Configurable auto-reload behavior * API error handling flows Configuration: - Added autoReloadOnTokenExpiry option to config.d.ts and app-config.yaml - Default behavior: auto-reload page on token expiry with countdown - Can be disabled to show error message instead Documentation: - Enhanced README.md with comprehensive testing instructions - Added development workflow and PR creation guide - Added manual linting commands and Backstage-specific rules - Included code quality commands and conventional commit examples - Added working directory information for all commands Code Quality: - Fixed linting issues (toLowerCase -> toLocaleLowerCase) - Fixed variable shadowing in error handlers - Added eslint-disable for pre-existing conditional hook call - All tests passing with 100% success rate Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
sriaradhyula
requested review from
sbraicu,
subbaksh and
suwhang-cisco
as code owners
November 8, 2025 12:27
Enhanced README documentation with: - Added CAIPE (Community AI Platform Engineering) overview and integration details - Updated A2A Protocol links to official documentation (a2a-protocol.org) - Clarified that Agent Forge works with any A2A-compatible agent - Added CAIPE community resources: * Community page with weekly meeting information * Slack channel (#cnoe-sig-agentic-ai) * GitHub issues for CAIPE-specific questions - Added configuration examples for CAIPE and custom A2A agents - Reorganized support section for clarity - Updated description to highlight A2A protocol compatibility Documentation now provides clear guidance for users integrating Agent Forge with CAIPE or any other A2A-compatible agent system. Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Merged agent-forge-upstream-docker branch into feat/agent-forge-401-auth-handling. Combined both features: - autoReloadOnTokenExpiry for automatic page reload on token expiry - enableFeedback with feedbackEndpoint for user feedback collection Resolved conflicts in: - config.d.ts: Added both autoReloadOnTokenExpiry and feedback config options - ChatbotApi.ts: Integrated both features in API options and implementation - AgentForgePage.tsx: Combined config reading and API initialization - yarn.lock: Accepted upstream changes Both features now work together seamlessly. Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
- Renamed metadata fields to use Jarvis-compatible naming - Changed MetadataField to PlatformEngineerInputField - Updated field names: field_name, field_description, field_values - Ensures consistency with A2A DataPart schema - Updated dependencies in yarn.lock Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
Signed-off-by: suwhang-cisco <suwhang@cisco.com>
suwhang-cisco
approved these changes
Nov 10, 2025
suwhang-cisco
left a comment
suwhang-cisco
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally and all looks good. Published npm @caipe/plugin-agent-forge@0.3.41
suwhang-cisco
merged commit Nov 10, 2025
272ca6f
into
agent-forge-upstream-docker
8 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented comprehensive 401 error handling for OpenID token authentication:
Configuration:
Documentation:
Code Quality:
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)