Upgrade Dockerfile and CI from Node 18 to Node 24 (LTS) - #55
Open
salmanmkc wants to merge 1 commit into
Open
Conversation
salmanmkc
force-pushed
the
upgrade-node-22
branch
from
April 30, 2026 10:28
c01ba45 to
c9827ed
Compare
salmanmkc
changed the title
salmanmkc
force-pushed
the
upgrade-node-22
branch
from
April 30, 2026 10:37
c9827ed to
77f742f
Compare
salmanmkc
changed the title
salmanmkc
force-pushed
the
upgrade-node-22
branch
from
April 30, 2026 10:41
77f742f to
7112708
Compare
Node 18 reached end-of-life on April 30, 2025. A transitive dependency (undici@7.25.0) requires Node >=20.18.1, causing both the Docker build and PR CI to fail during yarn install. Upgrade to Node 24 (Active LTS since October 2025, EOL April 2028): - Dockerfile: all three FROM stages updated to node:24-bookworm-slim - pr.yaml: setup-node version updated to 24 - package.json: engines field updated to include Node 22 and 24 Aligns with the Node 24 GitHub Actions runner upgrade in cnoe-io#52. Signed-off-by: Salman Chishti - SalmanMKC <13schishti@gmail.com>
salmanmkc
force-pushed
the
upgrade-node-22
branch
from
April 30, 2026 10:43
7112708 to
fec4bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the Docker base image and PR CI workflow from Node 18 to Node 24 (Active LTS) to fix broken builds.
Problem
The
build-and-push-imagejob and PR CI both fail duringyarn installbecause a transitive dependency (undici@7.25.0) requires Node>=20.18.1, but Node 18.20.8 is used:Fix
FROM node:18-bookworm-slimstages tonode:24-bookworm-slimsetup-nodeversion from 18 to 24Why Node 24?
Node 24 is the sole Active LTS release and aligns with the GitHub Actions runner upgrade to Node 24 in #52.
Related