Fix small (1-3 byte) user data packets being ignored - #130
Merged
Merged
Conversation
Owner
|
This looks good to me. @monte-monte what do you think? Also this is great. Should reduce code size. |
Contributor
|
I think it's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
length is already reduced by 3 at
rv003usb/rv003usb/rv003usb.c
Line 259 in 0326641
The result is that small user data packets (1-3 bytes) are dropped. This shows up when (for example) a feature has a 9 total byte length (
HID_REPORT_COUNT(8)+ 1 byte forHID_REPORT_ID) - the first 8 byte packet is passed tousb_handle_user_databut the second 1 byte packet is dropped.