Reject incomplete init_mixw models - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
When a destination base phone is absent from the source CI model, uniform mixture-weight initialization does not initialize the corresponding Gaussian codebook. The existing completeness checks only warn, after which
init_mixwwrites all destination files and returns success even though the acoustic-model initialization invariant is not satisfied.Fix
Record any uninitialized destination state or codebook, emit an error naming each incomplete index, and return failure before the first destination write. The existing transition-matrix fallback remains unchanged because it provides a complete initialization policy. Complete inputs follow the same path and produce identical output.
Verification
cmake -S . -B buildcmake --build buildThis mirrors the landed completeness gate in pstrain PR #127.