Skip to content

Reject incomplete init_mixw models - #71

Merged
lenzo-ka merged 1 commit into
masterfrom
kal-init-mixw-reject-incomplete
Aug 17, 2026
Merged

Reject incomplete init_mixw models#71
lenzo-ka merged 1 commit into
masterfrom
kal-init-mixw-reject-incomplete

Conversation

@lenzo-ka

Copy link
Copy Markdown
Contributor

Defect

When a destination base phone is absent from the source CI model, uniform mixture-weight initialization does not initialize the corresponding Gaussian codebook. The existing completeness checks only warn, after which init_mixw writes all destination files and returns success even though the acoustic-model initialization invariant is not satisfied.

Fix

Record any uninitialized destination state or codebook, emit an error naming each incomplete index, and return failure before the first destination write. The existing transition-matrix fallback remains unchanged because it provides a complete initialization policy. Complete inputs follow the same path and produce identical output.

Verification

  • cmake -S . -B build
  • cmake --build build

This mirrors the landed completeness gate in pstrain PR #127.

@lenzo-ka
lenzo-ka merged commit 7e1662e into master Aug 17, 2026
8 checks passed
@lenzo-ka
lenzo-ka deleted the kal-init-mixw-reject-incomplete branch August 17, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant