Fix inc_comp vector-length ownership - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
The means read gives
inc_compownership of aveclenallocation. The variance read reuses the same out-parameter, overwriting that pointer without releasing the first allocation.Fix
Release the means-read
veclenallocation and clear the pointer before the variance read establishes a new owner. This preserves the existing dimensions and output behavior while restoring the resource-ownership invariant.Verification
cmake -S . -B buildcmake --build buildThis is corroborated by the landed pstrain implementation in pstrain PR #134.