eigen: Update to upstream version 5.0.1#10712
Open
kopperp wants to merge 1 commit into
Open
Conversation
Contributor
|
A new Pull Request was created by @kopperp for branch IB/CMSSW_20_1_X/master. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
Contributor
|
please test with cms-sw/cmssw#51453 |
fwyzard
reviewed
Jul 8, 2026
| @@ -2,14 +2,12 @@ | |||
Contributor
There was a problem hiding this comment.
@kopperp please change this line to
-### RPM external eigen c1d637433e3b3f9012b226c2c9125c494b470ae6
+### RPM external eigen 5.0.1and below use %{realversion} in place of %{tag}.
Contributor
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a56970/54619/summary.html Failed External BuildI found compilation error when building: from tensorflow/lite/kernels/conv.cc:38: external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h: In instantiation of 'EigenForTFLite::TensorRef::TensorRef(const Expression&) [with Expression = EigenForTFLite::TensorMap, 16>; PlainObjectType = EigenForTFLite::Tensor]': external/local_tsl/tsl/framework/convolution/eigen_spatial_convolutions-inl.h:1609:7: required from 'std::conditional_t<(EigenForTFLite::internal::traits::Layout == EigenForTFLite::ColMajor), EigenForTFLite::TensorReshapingOp::Index, EigenForTFLite::internal::traits::NumDimensions>, const EigenForTFLite::TensorContractionOp::Index>, 1>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const Kernel>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const EigenForTFLite::TensorImagePatchOp<-1, -1, const Derived> >, const OutputKernel> >, EigenForTFLite::TensorReshapingOp::Index, EigenForTFLite::internal::traits::NumDimensions>, const EigenForTFLite::TensorContractionOp::Index>, 1>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const EigenForTFLite::TensorImagePatchOp<-1, -1, const Derived> >, const EigenForTFLite::TensorReshapingOp::Index, 2>, const Kernel>, const OutputKernel> > > EigenForTFLite::SpatialConvolution(const Input&, const Kernel&, Index, Index, PaddingType, Index, Index, const OutputKernel&, Index, Index, Index, Index) [with Input = TensorMap, 16>; Kernel = TensorMap, 16>; OutputKernel = const NoOpOutputKernel; std::conditional_t<(internal::traits::Layout == EigenForTFLite::ColMajor), TensorReshapingOp::Index, internal::traits::NumDimensions>, const TensorContractionOp::Index>, 1>, const TensorReshapingOp::Index, 2>, const Kernel>, const TensorReshapingOp::Index, 2>, const TensorImagePatchOp<-1, -1, const Derived> >, const OutputKernel> >, TensorReshapingOp::Index, internal::traits::NumDimensions>, const TensorContractionOp::Index>, 1>, const TensorReshapingOp::Index, 2>, const TensorImagePatchOp<-1, -1, const Derived> >, const TensorReshapingOp::Index, 2>, const Kernel>, const OutputKernel> > > = TensorReshapingOp, const TensorContractionOp, 1>, const TensorReshapingOp, const TensorImagePatchOp<-1, -1, const TensorMap, 16> > >, const TensorReshapingOp, const TensorMap, 16> >, const NoOpOutputKernel> >; typename internal::traits::Index = long int; typename internal::traits::Index = long int; Index = long int]' ./tensorflow/lite/kernels/internal/optimized/multithreaded_conv.h:130:36: required from 'void tflite::multithreaded_ops::EigenTensorConvFunctor::operator()(const EigenForTFLite::ThreadPoolDevice&, const T*, int, int, int, int, const T*, int, int, int, int, int, int, int, tflite::PaddingType, T*, int, int) [with T = float]' ./tensorflow/lite/kernels/internal/optimized/multithreaded_conv.h:171:15: required from here external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h:254:5: error: static assertion failed: "Expression must be mutable to create a mutable TensorRef. Did you mean " "TensorRef?)" 254 | EIGEN_STATIC_ASSERT(internal::is_lvalue::value, | ^~~~~~~~~~~~~~~~~~~ external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h:254:5: note: 'std::integral_constant::value' evaluates to false Target //tensorflow/tools/pip_package:wheel failed to build INFO: Elapsed time: 472.446s, Critical Path: 26.94s |
Contributor
|
Pull request #10712 was updated. |
Contributor
|
please test with cms-sw/cmssw#51453
|
Contributor
OK, so one problem is that the version of Tensorflow that we use does not like the new version of Eigen. |
Contributor
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a56970/54623/summary.html Failed External BuildI found compilation error when building: from tensorflow/lite/kernels/conv.cc:38: external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h: In instantiation of 'EigenForTFLite::TensorRef::TensorRef(const Expression&) [with Expression = EigenForTFLite::TensorMap, 16>; PlainObjectType = EigenForTFLite::Tensor]': external/local_tsl/tsl/framework/convolution/eigen_spatial_convolutions-inl.h:1609:7: required from 'std::conditional_t<(EigenForTFLite::internal::traits::Layout == EigenForTFLite::ColMajor), EigenForTFLite::TensorReshapingOp::Index, EigenForTFLite::internal::traits::NumDimensions>, const EigenForTFLite::TensorContractionOp::Index>, 1>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const Kernel>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const EigenForTFLite::TensorImagePatchOp<-1, -1, const Derived> >, const OutputKernel> >, EigenForTFLite::TensorReshapingOp::Index, EigenForTFLite::internal::traits::NumDimensions>, const EigenForTFLite::TensorContractionOp::Index>, 1>, const EigenForTFLite::TensorReshapingOp::Index, 2>, const EigenForTFLite::TensorImagePatchOp<-1, -1, const Derived> >, const EigenForTFLite::TensorReshapingOp::Index, 2>, const Kernel>, const OutputKernel> > > EigenForTFLite::SpatialConvolution(const Input&, const Kernel&, Index, Index, PaddingType, Index, Index, const OutputKernel&, Index, Index, Index, Index) [with Input = TensorMap, 16>; Kernel = TensorMap, 16>; OutputKernel = const NoOpOutputKernel; std::conditional_t<(internal::traits::Layout == EigenForTFLite::ColMajor), TensorReshapingOp::Index, internal::traits::NumDimensions>, const TensorContractionOp::Index>, 1>, const TensorReshapingOp::Index, 2>, const Kernel>, const TensorReshapingOp::Index, 2>, const TensorImagePatchOp<-1, -1, const Derived> >, const OutputKernel> >, TensorReshapingOp::Index, internal::traits::NumDimensions>, const TensorContractionOp::Index>, 1>, const TensorReshapingOp::Index, 2>, const TensorImagePatchOp<-1, -1, const Derived> >, const TensorReshapingOp::Index, 2>, const Kernel>, const OutputKernel> > > = TensorReshapingOp, const TensorContractionOp, 1>, const TensorReshapingOp, const TensorImagePatchOp<-1, -1, const TensorMap, 16> > >, const TensorReshapingOp, const TensorMap, 16> >, const NoOpOutputKernel> >; typename internal::traits::Index = long int; typename internal::traits::Index = long int; Index = long int]' ./tensorflow/lite/kernels/internal/optimized/multithreaded_conv.h:130:36: required from 'void tflite::multithreaded_ops::EigenTensorConvFunctor::operator()(const EigenForTFLite::ThreadPoolDevice&, const T*, int, int, int, int, const T*, int, int, int, int, int, int, int, tflite::PaddingType, T*, int, int) [with T = float]' ./tensorflow/lite/kernels/internal/optimized/multithreaded_conv.h:171:15: required from here external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h:254:5: error: static assertion failed: "Expression must be mutable to create a mutable TensorRef. Did you mean " "TensorRef?)" 254 | EIGEN_STATIC_ASSERT(internal::is_lvalue::value, | ^~~~~~~~~~~~~~~~~~~ external/eigen_archive/include/eigen3/unsupported/Eigen/CXX11/../src/Tensor/TensorRef.h:254:5: note: 'std::integral_constant::value' evaluates to false Target //tensorflow/tools/pip_package:wheel failed to build INFO: Elapsed time: 579.271s, Critical Path: 42.75s |
Contributor
|
Running tests here #10724 with the changes for eigen and tensorflow 2.21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eigen 3.5.0/5.0.0 added the necessary device header for CMSSW. Test to see if the CMS eigen fork can be dropped in favor of upstream.
Note:
Eigen 3.5.0/5.0.0 made fixed size matrices and arrays trivially_default_constructible. This uncovered two unused Eigen::Vector/Matrix variables in RecoTracker/PixelTrackFitting and is fixed in CMSSW!51453.