Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Use native Word/Lane types throughout pack.rs (instead of u64/u32) so the same source compiles cleanly on both 32-bit and 64-bit targets. Resolve the remaining clippy warnings (unnecessary_cast, let_and_return, too_many_arguments, needless_range_loop, type_complexity) that were failing the -D warnings CI run. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds a second clippy step to the existing Clippy job that runs with --cfg force_bits="32", catching Word-width-dependent lints like the unnecessary_cast warnings recently fixed in the NTT module. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Extract radix once in from_str_native to avoid repeated B as u32 casts, and silence the identity try_into() in num_traits::Num::from_str_radix on 32-bit Word targets. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Tests removed are fully subsumed by the schoolbook-comparison and roundtrip tests added later in development. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CokieMiner
pushed a commit
to CokieMiner/dashu
that referenced
this pull request
Jun 25, 2026
…e#74) * Add plan for NTT implementation * WIP: implemented ntt mul * WIP: tidy up * WIP: some param tuning * WIP: further tune b_pack * WIP: minor test improvements Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Some minor improvements Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Fix CI * Fix CI again * Change solinas to proth for NTT * Tidy up num-modular usage * Tune the NTT threshold * Tidy up * Remove todos * Fix 32-bit and clippy CI failures in NTT module Use native Word/Lane types throughout pack.rs (instead of u64/u32) so the same source compiles cleanly on both 32-bit and 64-bit targets. Resolve the remaining clippy warnings (unnecessary_cast, let_and_return, too_many_arguments, needless_range_loop, type_complexity) that were failing the -D warnings CI run. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * CI: run clippy on 32-bit Word target Adds a second clippy step to the existing Clippy job that runs with --cfg force_bits="32", catching Word-width-dependent lints like the unnecessary_cast warnings recently fixed in the NTT module. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Fix clippy warnings on 32-bit Word in dashu-float Extract radix once in from_str_native to avoid repeated B as u32 casts, and silence the identity try_into() in num_traits::Num::from_str_radix on 32-bit Word targets. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Remove development-only NTT tests Tests removed are fully subsumed by the schoolbook-comparison and roundtrip tests added later in development. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Fix fmt --------- Co-authored-by: Jacob Zhong <jacob@rimbot.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criterion comparison: master run against ssa baseline. Negative = master faster; positive = ssa faster.
ubig_mul_asymmetric — b fixed at 500k bits (~8k words), a varies
(ssa-only; this benchmark was added in the branch)