Use word instead of bool for add/sub carry chain - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the carry/borrow type in all architecture-specific add_with_carry and sub_with_borrow functions from bool to Word, and use comparison-based overflow detection on the generic
code path. This eliminates bool↔Word conversions in the inner loops and reduces the per-word instruction count from ~9 to ~7 on ARM64.
Changes
7 files, +49/−40 lines
Arch functions (integer/src/arch/{generic,x86,x86_64}/add.rs)
(ADDS+CSET+ADDS+CSINC instead of ADDS+CSET+ORR).
Hot loops (integer/src/add.rs)
Callers (integer/src/{mul,sqr}/simple.rs)
Benchmarks (Apple M-series, non-throttled)
ubig_add
At 10000-bit, dashu now beats malachite (140.5 ns).
ubig_sub
ubig_mul
At 100/1000 bits the values are inlined (1–2 words, or ~16 words where dispatch overhead dominates the inner loop), so the carry-chain change has negligible effect. The benefit
grows with operand size as the inner loop becomes the dominant cost.