Skip to content

fix: typo in color variable name + cross-platform IP detection fallback#1

Open
kbrenner-dev wants to merge 6 commits into
cmprmsd:mainfrom
kbrenner-dev:main
Open

fix: typo in color variable name + cross-platform IP detection fallback#1
kbrenner-dev wants to merge 6 commits into
cmprmsd:mainfrom
kbrenner-dev:main

Conversation

@kbrenner-dev

@kbrenner-dev kbrenner-dev commented Mar 19, 2026

Copy link
Copy Markdown

Fixes

1. Typo in cinelog.plugin.zsh

BAISC_MAGENTABASIC_MAGENTA

This typo means the variable is defined as BAISC_MAGENTA but any code referencing BASIC_MAGENTA would get an empty string instead of the magenta color escape code.

2. Cross-platform IP detection in http_server.py

The current implementation uses ip route get 1 | awk '{print $7}' which only works on Linux and fails silently on macOS/BSD. Added a socket-based fallback which works on all platforms.

3. Missing Python dependencies for hist

The hist script requires both docopt and prompt_toolkit, but the README only mentioned apt install python3-docoptprompt_toolkit was completely missing from the installation instructions, causing the script to fail on a fresh install.

Added requirements.txt with both dependencies and updated the README accordingly.

4. Hardcoded ~/.zim/modules/cinelog/ path

Both cinelog.plugin.zsh and http_server.py had the zim install path hardcoded, which breaks the plugin for anyone using oh-my-zsh, antigen, zplug, or a manual install.

Fix:

  • In cinelog.plugin.zsh: added CINELOG_DIR="${0:A:h}" — ZSH's built-in way to get the current script's directory at runtime, works with any plugin manager.
  • In http_server.py: replaced hardcoded path with os.path.dirname(os.path.realpath(__file__)) as fallback, also respects a CINELOG_DIR env var exported by the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant