use formatPrice across codebase - #294
Draft
cm-ayf wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes price formatting across the codebase by implementing a centralized formatPrice utility function that formats Japanese Yen prices consistently.
- Introduces a new
formatPricefunction in~/lib/price.tsthat usesIntl.NumberFormatfor proper currency formatting - Replaces all manual price formatting patterns throughout the codebase with calls to
formatPrice - Updates test expectations to use the standardized formatting function
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/lib/price.ts | Introduces the centralized formatPrice utility function |
| tests/register.test.ts | Updates test expectations to use formatPrice instead of manual string formatting |
| tests/receipts.test.ts | Updates test expectations to use formatPrice for consistency |
| tests/event.test.ts | Updates test expectations to use formatPrice throughout |
| app/routes/$guildId.$eventId.register._index/route.tsx | Replaces manual price formatting with formatPrice function |
| app/routes/$guildId.$eventId.receipts._index/Table.tsx | Updates DataGrid value formatter to use formatPrice |
| app/routes/$guildId.$eventId.receipts._index/Summary.tsx | Replaces complex inline currency formatting with formatPrice |
| app/routes/$guildId.$eventId._index/route.tsx | Updates discount display logic to use formatPrice |
| app/components/DisplayPanel.tsx | Replaces manual price formatting with formatPrice in component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cm-ayf
marked this pull request as draft
July 4, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #250