Add option to mark a CoSyLuigiTaskParameter as unique across all prior tasks - #3
Merged
Jekannadar merged 11 commits intoApr 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3 +/- ##
============================================
+ Coverage 94.87% 100.00% +5.12%
============================================
Files 4 11 +7
Lines 156 315 +159
Branches 9 21 +12
============================================
+ Hits 148 315 +167
+ Misses 7 0 -7
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![cls-python-workflows[bot]](https://avatars.githubusercontent.com/u/115809360?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark cosy-luigi
Details
| Benchmark suite | Current: de06a20 | Previous: 8d2ffc5 | Ratio |
|---|---|---|---|
benchmarks/test_benchmark_chain_100.py::test_benchmark_chain_creation |
0.6722896860372995 iter/sec (stddev: 0.008973499182957834) |
0.6608582640767512 iter/sec (stddev: 0.033524791798773636) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Jekannadar
force-pushed
the
feature/add-unique-constrains-on-task-parameters
branch
from
April 13, 2026 17:10
be77ad2 to
de06a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoSyLuigiTaskParametershave an optional parameterunique_across_prior_tasks.Setting this parameter to true automatically adds a constraint to the task that ensures that when a concrete task is picked for the parameter during synthesis, there can be no other instances of tasks that have the type of the
TaskParameteras supertype.If the optional parameter is applied to a
TaskParameterwhich requires a type for which the repository has no subtypes, i.e., there is no variance, a Warning it output, as there is a high chance that the user has misunderstood how variance via TaskParameters works.