Fix flatten not resolving abstractness on variant expansion - #18
Merged
Conversation
Bug caused because flatten relied on the output of variant expansion already being flat.
![cls-python-workflows[bot]](https://avatars.githubusercontent.com/u/115809360?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark cosy-luigi
Details
| Benchmark suite | Current: c6984a5 | Previous: 9399032 | Ratio |
|---|---|---|---|
benchmarks/test_benchmark_chain_100.py::test_benchmark_chain_creation |
0.7129955787318142 iter/sec (stddev: 0.009217149820574009) |
0.6638529947008243 iter/sec (stddev: 0.008475270702951928) |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 369 371 +2
Branches 23 23
=========================================
+ Hits 369 371 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug caused because flatten relied on the output of variant expansion already being flat. Variant expansion correctly expanded to all variants in the
mroof a class, but flatten is only interested in non-abstract variants.Fixed by filtering variant expansion output in flatten.