Repository navigation
fix: Mac issues & enable Linux build - #17
duyhungtnn wants to merge 12 commits into
Conversation
Append a troubleshooting note to cvm_create_mac_dmg.md advising users to try the Terminal app if the create-dmg command errors. Instructs to grant Automation permission (common on macOS 13+) via System Settings → Privacy & Security → Automation and enable the Finder toggle for the terminal app, then re-run the command.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d42fa59. Configure here.
| hashMd5Hex(d.constData(), d.size(), md5Hash); | ||
|
|
||
| if (!Core::Launcher::Instance().customWorkingDir()) { | ||
| QFile::remove(u"%1org.cloudveil.messenger._%2.desktop"_q.arg( |
There was a problem hiding this comment.
Stale QRC desktop resource path
High Severity
The GenerateDesktopFile function tries to load the org.telegram.desktop.desktop resource, but it was renamed to org.cloudveil.messenger.desktop. This prevents the embedded template from being read, so Linux desktop files (shortcuts, mime handlers) are not created for non-packaged runs like AppImage or portable installations.
Reviewed by Cursor Bugbot for commit d42fa59. Configure here.
| constexpr auto AppFile = "Telegram"_cs; | ||
| constexpr auto AppVersion = 5014003; | ||
| constexpr auto AppVersionStr = "5.14.3"; | ||
| constexpr auto AppVersionStr = "5.14.4"; |
There was a problem hiding this comment.
AppVersion numeric string mismatch
Medium Severity
AppVersion in version.h is 5014003, out of sync with the 5.14.4 release. This mismatch causes update checks, settings migration, and clientVersionCode to report an incorrect numeric version to services, even though the UI displays 5.14.4.
Reviewed by Cursor Bugbot for commit d42fa59. Configure here.
| Name=Telegram | ||
| Comment=New era of messaging | ||
| Name=CloudVeil Messenger | ||
| Comment=Secure messaging with CloudVeil |
There was a problem hiding this comment.
Packaged Linux wrong binary name
High Severity
The Linux binary's name changed to cloudveil-messenger, but the .desktop file's TryExec and Exec fields, and the D-Bus service, still reference telegram-desktop. This mismatch prevents the application from launching correctly via desktop entries or D-Bus activation.
Reviewed by Cursor Bugbot for commit d42fa59. Configure here.
| QString path = QDir::tempPath() + "/cvm_update_package.dmg"; | ||
| #else | ||
| QString path = QDir::tempPath() + "/cvm_update_package"; | ||
| #endif |
There was a problem hiding this comment.
Mac update launches DMG directly
Medium Severity
On macOS, the update mechanism saves the update file as a .dmg. The subsequent update process attempts to execute this .dmg directly. As disk images are not executables, in-app updates on macOS will likely fail after download.
Reviewed by Cursor Bugbot for commit d42fa59. Configure here.
Note
Medium Risk
Wide UI/policy changes plus a notification logic fix affect user-visible behavior; Linux Docker and Sentry wiring touch release infrastructure but are mostly packaging/build.
Overview
Releases 5.14.4 with CloudVeil bundle IDs, Linux XDG/desktop assets (
org.cloudveil.messenger), macOS Sentry (release_mac+DESKTOP_APP_USE_SENTRY), and platform-specific update package paths (.exe/.dmg/ generic).Policy & UX: Blocked peers are filtered from chat search, global search, channel suggestions, and bot mini-apps; the Apps tab and channel recommendations are hidden; the info/third panel is blocked for disallowed chats; forbidden dialogs now call
closeThirdSection(). Settings sync initializesmigratedFromTelegramIdand reports Linux asclientOsType. Desktop notifications are corrected so they only show whenisDialogAllowedis true (previously inverted).Build: CentOS Docker image uses Python 3.11 for meson/xcb/gobject-introspection and adjusts PipeWire session-managers for a working packaged Linux build.
Reviewed by Cursor Bugbot for commit d42fa59. Bugbot is set up for automated code reviews on this repo. Configure here.