Update Go toolchain to 1.27.1 and golangci-lint to v2.13.2 - #420
Merged
makenowjust merged 3 commits intoSep 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #410.
Renovate's #410 bumps the Go toolchain, but its CI fails because
bin/golangci-lintis pinned to v2.11.4 (built with go1.26), which refuses to analyze atoolchain go1.27.1module:Renovate can't fix this itself because the golangci-lint version lives inside a
curlcommand in the Makefile. This PR updates both together, superseding #410 (Renovate should close it automatically once this merges):go.mod:
toolchain go1.26.6→go1.27.1Makefile: golangci-lint v2.11.4 → v2.13.2 (go1.27 support landed in v2.13.0)
go.yml: use
go-version-file: go.modinstead of a hard-codedgo-version: "1.26", and move checkout before setup-go (required forgo-version-file; also fixes the existing "Restore cache failed: go.mod not found" warning caused by the old step order). With this, future toolchain bumps only touchgo.mod, so Renovate PRs no longer modify workflow files — which also keeps them clear of the zizmor changed-file checks.Makefile: install golangci-lint via
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2instead of theinstall.shcurl script. The script frommastercurrently fails checksum verification for all v2.13.x releases: theirchecksums.txtnow also lists*.tar.gz.sbom.jsonentries, and the script's basename grep matches the sbom line.go installis deterministic (verified via the Go module checksum database) and has no such parsing issue.Lint fixes: golangci-lint v2.13.2's updated
modernizelinter reported 4 new findings (slices.Backwardfor backward loops inast/walk.go/tools/gen-ast-walk,reflect.TypeAssertintools/parse/tools/util/poslang); applied viagolangci-lint run --fixwith minor cleanups.check-genconfirms generated code is unchanged.Verified locally:
make ci(check-gen, lint with v2.13.2, tests) passes on go1.27.1.