[John Lonetree (johnlonetree)]

what

• Read the region from aws_region.region instead of the deprecated aws_region.name.
• Raise the minimum AWS provider version from >= 4.7.0 to >= 6.0.
• Raise the AWS provider constraint in examples/complete and examples/external-eni to >= 6.0.
• Update the provider tables in the README.

why

• AWS provider v6 deprecates aws_region.name, so v6 users see a warning from this module.
• aws_region.region does not exist before provider v6, so the floor must go up.
• What breaks: this release no longer supports AWS provider v4 or v5.
• How to migrate: upgrade to AWS provider v6 first. A plan on an existing deployment (provider 6.69.1) showed no resource changes.

references

• closes Dependency on aws provider >5.0 #161
• closes Incorrect AWS provider version requirement #181
• aws_region data source
• Same fix: terraform-aws-vpc-peering-multi-account v2.0.1

[Erik Osterman (Cloud Posse) (osterman)]

Thanks. The change is correct. We label it major, not minor: this module is at v2, and it raises the minimum AWS provider from >= 4.7.0 to >= 6.0. Our policy: https://docs.cloudposse.com/community/contribute/faq/#what-impact-does-raising-the-minimum-terraform-or-provider-version-have-on-a-module

Nit: please use >= 6.0.0 (three-part form).

[Erik Osterman (Cloud Posse) (osterman)]

/terratest

[John Lonetree (johnlonetree)]

Excellent, thanks for the feedback, I've refactored the version number and it's now following semver convention. I've also changed this in the README, if this is not recommended I can convert this back.

[John Lonetree (johnlonetree)]

Hey Erik Osterman (Cloud Posse) (@osterman), just a gentle follow-up would there be anything else that would need to be updated, and are there any additional steps I would need to take before review?