Fix metric type fluctuates between counter and gauge for a given metric

[weili-broadcom]

Currently, if a counter metric's delta value fluctuates between 0 and non-0, it will lead to its metric type fluctuating between COUNTER and GAUGE in the otel prometheus exporter, thus getting dropped due to type conflict.

The solution is to keep counter metric to be counter type without considering its delta value

Description

Please include a summary of the change.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing performed?

• Unit tests
• Integration tests
• Acceptance tests

Checklist:

• This PR is being made against the main branch, or relevant version branch
• I have made corresponding changes to the documentation
• I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

[mkocher]

As a participant in creating the old logic I think this makes more sense than what we did the first time

[chombium]

LGTM! Thanks for the fix @weili-broadcom

We are not using the deltas in the metrics. Although we have them, we don't set them anywhere, but we set the total values, which means the metrics are always counters.

I will wait for the ci job to finish and merge it afterwards