Add application id to error messages for https_batch - #705
Conversation
chombium
left a comment
There was a problem hiding this comment.
Hi @nicklas-dohrn,,
thanks for the changes. The addition of the AppID works as expected, but I've found another missing thing in the error messages: the error messages show only the host of the Syslog Server. Generally speaking, this might not be enough, as someone can add many Syslog Servers on a single host, mapped to different paths.
Let's say there is a Syslog Drain created as follows:
cf cups my-drain-with-creds -l https-batch://user:pass@my-host/this/is/the/path?p1=v1&p2=v2
From the whole URL the creds and the query string should be removed (anonymized) and the error messages should contain https-batch://my-host/this/is/the/path.
Please take a look at the Fliltered Binding Fetcher for and example and implement it here the same way.
124588c to
b2e1da1
Compare
4ff5f9d to
b175d29
Compare
b175d29 to
c3490a0
Compare
chombium
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the quick changes @nicklas-dohrn
Description
This change fixes small oversights in Error reporting.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch