Remove "Thin" webserver - #4670
Merged
Merged
Conversation
* preparation for Thin removal * replace EventMachine with Concurrent::TimerTask * remove "thread_info_event_machine" metrics
* explicitly start and stop MetricsWebserver with Prometheus middleware
* Rack expects an enumerable. An empty string doesn't work (it worked for Thin, though).
jochenehret
marked this pull request as ready for review
November 21, 2025 15:08
philippthun
reviewed
Dec 5, 2025
philippthun
left a comment
philippthun
left a comment
Member
There was a problem hiding this comment.
Only some smaller spec improvements...
* was only used for Thin/EventMachine
philippthun
approved these changes
Dec 5, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Dec 5, 2025
Changes in cloud_controller_ng:
- Remove "Thin" webserver
PR: cloudfoundry/cloud_controller_ng#4670
Author: Jochen Ehret <jochen.ehret@sap.com>
sethboyles
pushed a commit
to atanas-attodorov-wq/cloud_controller_ng
that referenced
this pull request
Dec 11, 2025
* Remove EventMachine from Puma * preparation for Thin removal * replace EventMachine with Concurrent::TimerTask * remove "thread_info_event_machine" metrics * Remove Thin webserver * Update metrics_spec.rb test * explicitly start and stop MetricsWebserver with Prometheus middleware * Fix Rack response for Puma webserver * Rack expects an enumerable. An empty string doesn't work (it worked for Thin, though). * Fix CORS unit test * Shutdown metrics_webserver after each test * Simplify specs (remove redundancies) * Remove "threadpool_size" config parameter * was only used for Thin/EventMachine * Simplify spec: Extract duplicate double(:server) setup
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Remove the deprecated "Thin" webserver and also the "EventMachine" leftovers.
An explanation of the use cases your change solves
Removes deprecated Gems and coding.
Links to any other associated PRs
Roadmap for Thin removal #4115
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests