Re-implement SSHKey to remove sshkey gem dependency - #4643
Merged
Conversation
johha
force-pushed
the
remove-ssh-key-gem
branch
from
November 4, 2025 17:23
624fe2d to
d07e292
Compare
Refactor the `VCAP::CloudController::Diego::SSHKey` class to remove the dependency on the `sshkey` gem. This change reduces external dependencies and avoids potential compilation issues related to native extensions. The class is re-implemented using the standard `openssl` and `digest` libraries. The public interface and output formats of the `private_key`, `authorized_key`, `fingerprint` (SHA1), and `sha256_fingerprint` methods are preserved, ensuring it acts as a transparent, drop-in replacement. The performance impact is negligible as the most expensive operation, RSA key generation, still relies on OpenSSL, and all derived values are memoized.
johha
force-pushed
the
remove-ssh-key-gem
branch
from
November 4, 2025 17:25
d07e292 to
37c3df7
Compare
johha
marked this pull request as ready for review
November 5, 2025 11:38
jochenehret
approved these changes
Nov 6, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Nov 6, 2025
Changes in cloud_controller_ng:
- Re-implement SSHKey to remove sshkey gem dependency
PR: cloudfoundry/cloud_controller_ng#4643
Author: Johannes Haass <johannes.haass@sap.com>
sethboyles
pushed a commit
to atanas-attodorov-wq/cloud_controller_ng
that referenced
this pull request
Dec 11, 2025
Refactor the `VCAP::CloudController::Diego::SSHKey` class to remove the dependency on the `sshkey` gem. This change reduces external dependencies and avoids potential compilation issues related to native extensions. The class is re-implemented using the standard `openssl` and `digest` libraries. The public interface and output formats of the `private_key`, `authorized_key`, `fingerprint` (SHA1), and `sha256_fingerprint` methods are preserved, ensuring it acts as a transparent, drop-in replacement. The performance impact is negligible as the most expensive operation, RSA key generation, still relies on OpenSSL, and all derived values are memoized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the
VCAP::CloudController::Diego::SSHKeyclass to remove the dependency on thesshkeygem. This change reduces external dependencies and avoids potential compilation issues related to native extensions.The class is re-implemented using the standard
opensslanddigestlibraries. The public interface and output formats of theprivate_key,authorized_key,fingerprint(SHA1), andsha256_fingerprintmethods are preserved, ensuring it acts as a transparent, drop-in replacement.The performance impact is negligible as the most expensive operation, RSA key generation, still relies on OpenSSL, and all derived values are memoized.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests on BBL env with FIPS stemcell (fips-snape)