Skip to content

fix broken path traversal test#224

Merged
mkocher merged 1 commit into
masterfrom
fix-cgroup-acceptance-test-scope-naming
Jun 24, 2026
Merged

fix broken path traversal test#224
mkocher merged 1 commit into
masterfrom
fix-cgroup-acceptance-test-scope-naming

Conversation

@mkocher

@mkocher mkocher commented Jun 24, 2026

Copy link
Copy Markdown
Member

Remind me not to trust LLMs to run the unit tests they write

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dea04190-c3fa-4837-90ec-9ceb5d549457

📥 Commits

Reviewing files that changed from the base of the PR and between 7866e93 and 46a5143.

📒 Files selected for processing (1)
  • src/bpm/acceptance/fixtures/test-server/handlers/cgroup_limits_test.go

Walkthrough

The test suite for the CgroupLimits path traversal guard in cgroup_limits_test.go is updated. The existing DescribeTable rejection entries (covering "parent traversal", "double traversal", and a URL-decoded traversal) are replaced with three new Entry cases: one-level-above the cgroup root, three-levels-above the cgroup root, and a traversal starting inside a subtree. A new It block is also added to assert that a ..-based path that remains within the cgroup root does not produce an "escapes" error in the response.

Suggested reviewers

  • selzoc
  • aramprice
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: updating the cgroup path traversal test cases.
Description check ✅ Passed The description is related to the test changes, even though it's informal and light on detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-cgroup-acceptance-test-scope-naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mkocher mkocher merged commit fae21eb into master Jun 24, 2026
5 checks passed
@mkocher mkocher deleted the fix-cgroup-acceptance-test-scope-naming branch June 24, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant