Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/install-dependencies/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: "Install Dependencies"
description: "Install dependencies, fetching from cache when possible"
inputs:
# We run all jobs on Node.js 22 by default, as this is the most stable and supported version right now.
#
# Pinned to 22.23.1 (rather than floating `22`) until it's safe to float back:
# Node 22.23.0 regressed node-fetch@2 keep-alive responses with
# ERR_STREAM_PREMATURE_CLOSE (nodejs/node#63989, fixed in 22.23.1).
Comment thread
petebacondarwin marked this conversation as resolved.
node-version:
description: the version of Node.js to install
default: 22
default: 22.23.1
turbo-api:
description: the api URL for connecting to the turbo remote cache
turbo-team:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ jobs:
# rather than restoring from a (potentially poisoned) cache.
uses: ./.github/actions/install-dependencies
with:
node-version: 24
# Pinned to 24.18.0 (rather than floating `24`) until it's safe to
# float back: Node 24.17.0 regressed node-fetch@2 keep-alive responses
# with ERR_STREAM_PREMATURE_CLOSE (nodejs/node#63989, fixed in 24.18.0).
node-version: 24.18.0
disable-cache: "true"

- name: Check npm version
Expand Down Expand Up @@ -74,7 +77,10 @@ jobs:
- name: Switch to Node 22 for non-npm package deployments
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22
# Pinned to 22.23.1 (rather than floating `22`) until it's safe to
# float back: Node 22.23.0 regressed node-fetch@2 keep-alive responses
# with ERR_STREAM_PREMATURE_CLOSE (nodejs/node#63989, fixed in 22.23.1).
node-version: 22.23.1

- name: Deploy non-NPM Packages
id: deploy
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/e2e-wrangler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ jobs:
if: steps.changes.outputs.everything_but_markdown == 'true'
uses: ./.github/actions/install-dependencies
with:
# Pin until `node-version: 22` resolves to 22.23.1 or later. Node 22.23.0
# regressed node-fetch@2 chunked/gzip responses with ERR_STREAM_PREMATURE_CLOSE.
node-version: 22.23.1
turbo-api: ${{ secrets.TURBO_API }}
turbo-team: ${{ secrets.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/test-and-check-other-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,17 @@ jobs:
# expected_to_fail: if true, tests may fail on this Node version.
# These versions are skipped on normal PRs but run on Version Packages PRs
# (changeset-release/main) or when the 'ci:test-all-node-versions' label is added.
#
# Node 24 is pinned to 24.18.0 (rather than floating `24`): Node 24.17.0
# regressed node-fetch@2 keep-alive responses with ERR_STREAM_PREMATURE_CLOSE
# (nodejs/node#63989, fixed in 24.18.0). `description` stays "Node 24" to
# keep the job/check name stable.
include:
- { node_version: 24, description: "Node 24", expected_to_fail: true }
- {
node_version: 24.18.0,
description: "Node 24",
expected_to_fail: true,
}
- { node_version: 25, description: "Node 25", expected_to_fail: true }

steps:
Expand Down
Loading