fix(flagship_flag): remove extraneous flag_key, use key as canoical identifier instead - #7308
Open
repository wants to merge 1 commit into
Open
fix(flagship_flag): remove extraneous flag_key, use key as canoical identifier instead#7308repository wants to merge 1 commit into
flag_key, use key as canoical identifier instead#7308repository wants to merge 1 commit into
Conversation
3 tasks
…al identifier instead
repository
force-pushed
the
lngo/fix-flag-key
branch
from
August 13, 2026 22:10
166fdf6 to
1582e45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, creation of
flagship_flagresources will use thekeyattribute, and the API would returnkeyin the response body. the provider will store theKeywith whatever was returned, but left theFlagKeyvalue in the state empty.when the provider then tries to refresh state or perform any updates, via the
/accounts/{account_id}/flagship/apps/{app_id}/flags/{flag_key}endpoint, the underlying SDK will reject it as the provider attempts to pass an emptyFlagKeyvaluethese two values refer to the same identifier for flagship flags, but have different naming for the request/response body vs. the path parameter variants
Changes being requested
flag_keyattributes on theflagship_flagresource/data sourceflag_keyattribute to schema 501 withkeyinsteaddata.Key.ValueString()in place ofdata.FlagKey.ValueString()in all SDK clalsAcceptance test run results
Steps to run acceptance tests
N/A
Test output
N/A
Additional context & links
https://jira.cfdata.org/browse/APIX-1389
#7178