Repository navigation
Drop Debian 11 and cleanups - #19
Merged
Merged
Conversation
Debian 11 reached end of life when Debian LTS support ended in August 2026, so we should not publish new packages for it. It was also already redundant: bullseye was added in 57811b5 to be the old-toolchain builder for Erlang releases that bookworm could not build (< 24.2). Since the cutoff was raised to 24.2 in f22bf3e that role no longer exists, leaving bullseye as a duplicate of bookworm on an older glibc. Packages already published to PackageCloud are untouched and stay available for anyone still pinned to bullseye; this only stops new builds.
Both pins guarded against Ruby versions no build image ships any more: * public_suffix 4.0.7 was needed for Ruby <= 2.5 (bionic/stretch era), already unreachable before this change. * dotenv 2.8.1 was needed for Ruby < 3.0, and bullseye (Ruby 2.7) was the last image that hit it. The remaining images ship Ruby 3.0 (jammy) or newer, so both conditionals always take the skip branch. Install fpm directly instead.
HiPE was removed from the build system before our minimum supported version: erts/configure has no hipe references at either OTP-24.2 or OTP-29.1, so configure has been ignoring this flag (with an "unrecognized options" warning) across the entire supported range.
The versions section only listed the Ubuntu releases, even though Debian has been in the build matrix since 955e6f7.
Tags and branches are mutable, so a compromised or retagged action runs with our PACKAGECLOUD_TOKEN and id-token write permission. Pin all three actions to a commit SHA, with the human-readable version in a trailing comment so it stays greppable and Dependabot can still bump them. ruby/setup-ruby@v1 was the weakest of the three: v1 is a branch there, not a tag, so every run picked up whatever it pointed at. actions/checkout goes from v4 to v7 in the same step. v7 blocks checking out fork PR refs for pull_request_target and workflow_run, and v6 moved credential persistence to a separate file. Neither affects this workflow: it triggers on pull_request, workflow_dispatch, schedule and push, checks out without a ref override and never reuses the credentials afterwards.
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
All reviewed changes are focused and no unresolved issues were found.
Review effort: Balanced
Findings: None
What changed in this PR
Drops Debian 11 support and removes obsolete build configuration while securely pinning GitHub Actions.
Changes:
- Removes Debian Bullseye from builds.
- Removes obsolete Ruby gem pins and
--disable-hipe. - Documents supported distributions.
- Pins upgraded GitHub Actions to commit SHAs.
| File | Description |
|---|---|
README.md |
Documents supported distributions. |
Dockerfile |
Removes obsolete gem pins and configure flag. |
bin/missing-versions |
Removes Debian Bullseye builds. |
.github/workflows/build-all-and-upload.yml |
Upgrades and SHA-pins actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
walro
marked this pull request as ready for review
September 24, 2026 10:50
walro
requested review from
LoisSotoLopez,
gomoripeti,
nordlundj and
oskgu360
as code owners
September 24, 2026 10:50
oskgu360
approved these changes
Sep 24, 2026
| --enable-shared-zlib \ | ||
| --disable-builtin-zlib \ | ||
| --disable-sctp \ | ||
| --disable-hipe \ |
There was a problem hiding this comment.
AFAIU this is because we no longer build for erlang versions lower to OTP 24, where HiPE was completely removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will merge with rebase strategy, see individual commits!