Repository navigation
Conversation
7 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring the AMQP authentication mechanism used during connection negotiation, allowing callers (and AMQP_URL) to specify mechanisms like PLAIN or EXTERNAL.
Changes:
- Add an
auth_mechanismparameter toAMQP::Clientconstruction/start flows and propagate it into the connection handshake. - Parse
auth_mechanismfromAMQP_URLquery parameters and from URI-based client construction. - Add a spec suite covering defaulting, URI parsing, and unsupported mechanism handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/amqp-client/connection.cr | Propagates auth_mechanism into StartOk and selects the appropriate response payload. |
| src/amqp-client.cr | Adds auth_mechanism to client configuration, env/URI parsing, and passes it into Connection.start. |
| spec/auth_mechanism_spec.cr | Adds coverage for defaulting, explicit mechanism selection, URI parsing, and unsupported mechanism errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Validate auth_mechanism early in `connect` to fail fast without network I/O - Use a dedicated `plain_response` variable for clarity - Raise `AMQP::Client::Error` instead of `ArgumentError` for consistency Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address Copilot review feedback: mechanisms passed via constructor, setter, URI, or env are now upper-cased to their canonical form, so values like "plain"/"external" are accepted instead of rejected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow to specify the
auth_mechanismin the connection