[VM/PublicIP] Fix: Resolve default-PublicIP assign/unassign bugs across AWS/NCP/KT/OpenStack/NHN - #1829
Merged
cb-spider merged 2 commits intoSep 4, 2026
Conversation
powerkimhub
commented
Sep 4, 2026
Member
- Add assign-publicip-true test suite (true→false→true lifecycle), mirroring assign-publicip-false, across all 10 CSPs
- Fix AWS RemoveDefaultPublicIP AuthFailure caused by an unnormalized "Not set" StsToken sentinel
- Fix NCP RemoveDefaultPublicIP 400 error: match by ServerInstanceNo instead of a bogus ServerName, and wait for the PublicIP's async state to settle before Disassociate/Delete
- Fix KT resolveVMPrivateIP: replace the unreliable ports.List call with the existing GetVM()-based lookup
- Fix OpenStack/NHN GetVM: clear PublicIP when the live floating-IP lookup finds nothing, instead of leaving a stale value
- Add read-after-write wait in common-runtime's AssignVMDefaultPublicIP so a just-assigned PublicIP is reliably visible on the next GetVM
- Fix test script to preserve already-captured PrivateIP/PublicIP/SSH fields on later-step failures instead of blanking them
…/KT/OpenStack/NHN
|
Could you please check and revise Korean texts? cloud-control-manager/cloud-driver/drivers/ncp/resources/PublicIPHandler.go 12:+// PublicIpInstanceOperation ("공인IP인스턴스OP") - e.g. a just-completed |
Member
Author
|
[Test Results]
|
cb-spider
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.