Creating 4k sample video#59
Merged
Merged
Conversation
iambalaam
commented
May 20, 2026
iambalaam
commented
Contributor
- Learnt how to force the cypress tests to run at different resolutions in CI
- Found out my previous way was wrong (and renamed the incorrect test video)
chetbox
reviewed
May 20, 2026
| '-c:v', | ||
| 'libx264', | ||
| // pixel format | ||
| 'libx265', |
Contributor
There was a problem hiding this comment.
This is now generating H265 videos by default. Did you mean to commit that?
I assume this is just a utility script and isn't actually used in the tests or build?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not the most polishsed thing in the world, but just trying to document everything as I go.
Also it's probably good to commit these videos to share without any chance of compression
chetbox
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.