Fixing looping logic#58
Merged
Merged
Conversation
chetbox
reviewed
May 20, 2026
| if (nextTemporalKeyframe?.[1]?.set?.t === 0) { | ||
| const timeRemaining = (mediaElement.duration - properties.t) / properties.rate; | ||
| const timeUntilKeyframe = nextTemporalKeyframe[0] - properties.t; | ||
| const timeRemaining = (mediaElement.duration * 1000 - properties.t) / properties.rate; |
chetbox
reviewed
May 20, 2026
chetbox
left a comment
chetbox
left a comment
Contributor
There was a problem hiding this comment.
Let's add a test for setting loop on a video element?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, looping videos without
Syncenabled performs the seek ahead behaviour and waits at 1s each time.Now the looping behaviour feels identical to the default HTML video loop
In this janky little video, I've got a normal looping video element in the top left
Underneath it covering the whole screen is a looping video from COGS that doesn't have sync on.
(they're not meant to be in time at all, but you can see when it loops the arrows pause for the same amount of time)
You can see that the arrows pause
20260519_111349.mp4