Skip to content

Remove unused message type "cogs_environment"#53

Merged
tomdixon merged 1 commit into
mainfrom
remove-unused-message-type
May 11, 2026
Merged

Remove unused message type "cogs_environment"#53
tomdixon merged 1 commit into
mainfrom
remove-unused-message-type

Conversation

@tomdixon

@tomdixon tomdixon commented May 7, 2026

Copy link
Copy Markdown
Contributor

This is a remnant of the HTTP/2 asset server system which is no longer in use

@tomdixon tomdixon requested a review from chetbox May 7, 2026 09:52
@chetbox

chetbox commented May 7, 2026

Copy link
Copy Markdown
Contributor

I believe we're still sending a message that looks like this to the Media Master: https://github.com/clockwork-dog/cogs/blob/main/src/server/socketServer.ts#L652

Should we remove this as well?

@chetbox

chetbox commented May 7, 2026

Copy link
Copy Markdown
Contributor

Should we remove this as well?

It feels to me like a useful bit of info we could hang conditional logic on in the future if we need specific behaviour for a COGS version. (Not a neat solution, but potentially a useful escape hatch.)

Maybe we should make use of this type in the implementation?

@tomdixon

Copy link
Copy Markdown
Contributor Author

Should we remove this as well?

It feels to me like a useful bit of info we could hang conditional logic on in the future if we need specific behaviour for a COGS version. (Not a neat solution, but potentially a useful escape hatch.)

Maybe we should make use of this type in the implementation?

Agreed we can remove and are also removing from COGS side

@tomdixon tomdixon merged commit f9c5cb0 into main May 11, 2026
5 checks passed
@tomdixon tomdixon deleted the remove-unused-message-type branch May 11, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants