Skip on-click handling in contenteditable areas - #11
Open
bplubell wants to merge 1 commit into
Open
Conversation
Default browser behavior is to NOT navigate to links that are marked as editable. Previously, links inside contenteditable areas that did not pass the conditions in the on-click handler (e.g. if they had a scheme and different origin) would behave as expected. However, links that did pass the conditions (e.g. if they were relative) would navigate, which does not match browser default behavior. Notably, elements inside of a <div contenteditable="true"> may be override that, making them un-editable. When a link does that, the browser *does* navigate. This change will also navigate, mimicking browser behavior as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default browser behavior is to NOT navigate to links that are marked as editable. Previously, links inside contenteditable areas that did not pass the conditions in the on-click handler (e.g. if they had a scheme and different origin) would behave as expected. However, links that did pass the conditions (e.g. if they were relative) would navigate, which does not match browser default behavior.
Notably, elements inside of a
<div contenteditable="true">may be override that, making them un-editable. When a link does that, the browser does navigate. This change will also navigate, mimicking browser behavior as expected.Fixes #10