Skip to content

fix(terminal): stop routing terminal clipboard writes through OSC 52 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binghaobhw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(terminal): stop routing terminal clipboard writes through OSC 52 #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions web-ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion web-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"@sentry/react": "^10.45.0",
"@tailwindcss/vite": "^4.2.1",
"@trpc/client": "^11.11.0",
"@xterm/addon-clipboard": "^0.2.0",
"@xterm/addon-fit": "^0.11.0",
"@xterm/addon-unicode11": "^0.9.0",
"@xterm/addon-web-links": "^0.12.0",
Expand Down
9 changes: 7 additions & 2 deletions web-ui/src/terminal/persistent-terminal-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { ClipboardAddon } from "@xterm/addon-clipboard";
import { FitAddon } from "@xterm/addon-fit";
import { Unicode11Addon } from "@xterm/addon-unicode11";
import { WebLinksAddon } from "@xterm/addon-web-links";
Expand Down Expand Up @@ -189,7 +188,13 @@ class PersistentTerminal {
rows: initialGeometry.rows,
});
this.terminal.loadAddon(this.fitAddon);
this.terminal.loadAddon(new ClipboardAddon());
// Not loading ClipboardAddon intentionally: it relays OSC 52 clipboard-set
// requests from whatever CLI is running in the terminal (e.g. Claude Code's
// own select-to-copy) into navigator.clipboard.writeText() with no active
// user gesture, which corrupts multi-byte CJK text. The addon's own base64
// decode is not at fault (verified correct); the Cmd+C handler below calls
// the same API but synchronously inside a real keydown event, and is
// unaffected. See https://github.com/cline/kanban/issues/574.
this.terminal.loadAddon(new WebLinksAddon());
this.terminal.loadAddon(this.unicode11Addon);
this.terminal.unicode.activeVersion = "11";
Expand Down