feat(dia.Paper): add focusin and focusout events - #3481
Open
kumilingus wants to merge 2 commits into
Open
Conversation
The paper turns the (bubbling) native focusin/focusout DOM events into cell:/element:/link:/blank: paper events, following the mouseover/ mouseout pattern — so applications can react to keyboard focus on cells (e.g. focusable cells via the root tabindex attribute) without binding native DOM listeners on the paper element.
A focus event outside of a cell view carries no useful information — keep the API surface to the cell:/element:/link: variants.
kumilingus
force-pushed
the
feat/paper-focus-events
branch
from
August 24, 2026 20:57
a02a8fe to
b9a30b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
focusin/focusoutpaper events with thecell:/element:/link:variants, following themouseover/mouseoutpattern (same guard, samefindViewresolution,cell:*fired beforeelement:*/link:*via the viewnotifychain).focusin/focusoutbubble natively, so the existing event delegation handles them without any special-event mapping.normalizeEventis not applied (nothing to normalize on focus events). Noblank:variants — a focus event outside of a cell view carries no useful information.Motivation
Making cells keyboard-focusable (
tabindexon the root viaattrs) is a common accessibility approach; reacting to the focus currently requires a native DOM listener onpaper.el. With this change:Changes
dia/Paper.mjs—focusin/focusoutin theeventshash + handlersdia/CellView.mjs,dia/ElementView.mjs,dia/LinkView.mjs—focusin/focusoutmethods notifyingcell:/element:/link:eventstypes/dia.d.ts— the 6 new event signaturestest/jointjs/paper.js— event order + no event outside of cell views (native bubblingFocusEvents; the test$.fn.triggershim dispatches non-bubblingCustomEvents)@joint/core: minor)