types(dia): infer view type from the model in view lookups

.changeset/view-lookup-typings.md

@@ -0,0 +1,5 @@
+---
+"@joint/core": patch
+---
+
+types - view lookups (`cell.findView()`, `paper.findViewByModel()`, `paper.getCellView()`) now infer the view type from the model and include the absent-view case in the return type

packages/joint-core/types/dia.d.ts

@@ -752,7 +752,7 @@ export class Cell<A extends ObjectHash = Cell.Attributes, S extends mvc.ModelSet
 
     addTo(graph: Graph, opt?: Graph.Options): this;
 
-    findView(paper: Paper): CellView;
+    findView(paper: Paper): CellView | undefined;
 
     isLink(): this is Link;
 
@@ -918,6 +918,8 @@ export class Element<A extends ObjectHash = Element.Attributes, S extends mvc.Mo
 
     constructor(attributes?: DeepPartial<A>, opt?: Element.ConstructorOptions);
 
+    findView(paper: Paper): ElementView | undefined;
+
     translate(tx: number, ty?: number, opt?: Element.TranslateOptions): this;
 
     position(opt?: Element.PositionOptions): g.Point;
@@ -1053,6 +1055,8 @@ export class Link<A extends ObjectHash = Link.Attributes, S extends mvc.ModelSet
      */
     labelMarkup?: string | MarkupJSON; // default label markup
 
+    findView(paper: Paper): LinkView | undefined;
+
     disconnect(): this;
 
     source(): Link.EndJSON;
@@ -2070,8 +2074,16 @@ export class Paper extends mvc.View<Graph> {
 
     findView<T extends ElementView | LinkView>(element: mvc.$SVGElement): T;
 
-    findViewByModel<T extends ElementView | LinkView>(model: Graph.CellRef): T;
+    findViewByModel(model: Element): ElementView | undefined;
+    findViewByModel(model: Link): LinkView | undefined;
+    findViewByModel(model: Cell | Cell.ID): CellView | undefined;
+    /** @deprecated Pass the model and let the view type be inferred. */
+    findViewByModel<T extends ElementView | LinkView>(model: Graph.CellRef): T | undefined;
 
+    getCellView(model: Element): ElementView | null;
+    getCellView(model: Link): LinkView | null;
+    getCellView(model: Cell | Cell.ID): CellView | null;
+    /** @deprecated Pass the model and let the view type be inferred. */
     getCellView<T extends ElementView | LinkView>(model: Graph.CellRef): T | null;
 
     /**

packages/joint-react/src/store/clear-view.ts

@@ -99,7 +99,6 @@ export function clearConnectedLinkViews(
     linkView._sourceMagnet = null;
     // @ts-expect-error we use private jointjs api method
     linkView._targetMagnet = null;
-    // @ts-expect-error we use private jointjs api method
     linkView.requestConnectionUpdate({ async: true });
     changes.set(String(link.id), { type: 'change', data: link });
   }

packages/joint-react/stories/examples/dynamic-status-icons/code.tsx

@@ -228,7 +228,9 @@ function Main() {
   useOnElementsMeasured(({ isInitial, paper }) => {
     if (!isInitial) return;
     for (const element of graph.getElements()) {
-      StatusList.add(element.findView(paper), 'root', 'status', {
+      const elementView = element.findView(paper);
+      if (!elementView) continue;
+      StatusList.add(elementView, 'root', 'status', {
         attribute: 'status',
         position: 'top-right',
         margin: { right: 5, top: 5 },

packages/joint-react/stories/examples/element-controls/code.tsx

@@ -740,7 +740,7 @@ function addElementControls(paper: dia.Paper) {
     const factory = controlMap[type];
     if (!factory) continue;
     const toolsView = new dia.ToolsView({ tools: [factory()] });
-    element.findView(paper).addTools(toolsView);
+    element.findView(paper)?.addTools(toolsView);
   }
 }
 

packages/joint-react/stories/examples/portal-selectors/code.tsx

@@ -219,6 +219,7 @@ function Selection({ selectedId }: { selectedId: CellId | null }) {
     if (!cell) return;
 
     const view = paper.findViewByModel(cell);
+    if (!view) return;
     highlighters.mask.add(view, 'root', 'selection', {
       padding: 8,
       layer: dia.Paper.Layers.FRONT,