feat(joint-core): add Paper.getCellView() for strict view lookup#3377
Open
kumilingus wants to merge 1 commit into
Open
feat(joint-core): add Paper.getCellView() for strict view lookup#3377kumilingus wants to merge 1 commit into
kumilingus wants to merge 1 commit into
Conversation
Side-effect-free counterpart to findViewByModel: returns the real CellView if instantiated, null otherwise. Does not resolve view placeholders and does not schedule view updates. Adopt in Paper pointermove/pointerup handlers — the cached sourceView liveness check has no reason to resolve a placeholder mid-drag. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paper.getCellView(cellOrId)returning the realCellViewif instantiated,nullotherwise.findViewByModel, it does NOT resolve view placeholders and does NOT schedule view updates — pure lookup.pointermove/pointeruphandlers, where the cachedsourceViewis only being probed for liveness mid-drag (no reason to force-resolve a placeholder).findViewByModelgetCellViewundefinednullCellViewexistsnullMotivation: consumers (joint-react cleanup paths, downstream apps) need to ask "do we already have a rendered view for this cell?" without inadvertently materializing a placeholder. Today the only options are
findViewByModel(side-effectful) or reaching into privatepaper._views[id].Test plan
yarn lintcleanyarn test-tscleankarma:joint— 1984/1984 pass (newpaper.getCellView()QUnit module covering instantiated cell, unknown id, and placeholder-only paths viaviewport: () => false+viewManagement: { lazyInitialize: true })🤖 Generated with Claude Code