fix(xml_bind): namespace collision#672
Merged
Merged
Conversation
olofhagsand
reviewed
Jul 4, 2026
olofhagsand
left a comment
olofhagsand
left a comment
Member
There was a problem hiding this comment.
The xsibling code further down in xml_bind_yang0_opt:
else if (xsibling &&
(xs = xml_find_type(xsibling, prefix, name, CX_ELMNT)) != NULL){
also suffers from a similar issue.
Summarizing, the fix is correct, but the code needs a restructuring for the xsibling optimization along with the yang check to be clearer.
I will pull this in and modify it in master.
| new "kill old backend" | ||
| $clixon_backend -z -f $cfg >/dev/null 2>&1 || true | ||
| new "start backend -s startup -f $cfg" | ||
| $clixon_backend -D $DBG -s startup -f $cfg |
Member
There was a problem hiding this comment.
Please use the start_backend to mimic other tests
|
|
||
| if [ $BE -ne 0 ]; then | ||
| new "Kill backend" | ||
| $clixon_backend -z -f $cfg |
| if (xml2ns(xt, xml_prefix(xt), &ns) < 0) | ||
| goto done; | ||
| ns_resolved++; | ||
| nsy = yang_find_mynamespace(y); |
Member
There was a problem hiding this comment.
NULL return is actually an error and should goto fail, but is harmless here, and if checked should have been tested earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
propose to fix issue 670