Claude/audit script analysis 9 tf lb - #3
Merged
Conversation
Replace string-based QEMU argument building with proper bash arrays. This eliminates reliance on word splitting and resolves SC2086 warnings. https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
- Add -r flag to remaining read calls (SC2162) - Replace ls | grep with glob for network interfaces (SC2010) - Use kill -0 $QEMU_PID instead of pgrep in runsystem (SC2034) - Quote $NOVNC_PID references - Remove unreachable return after exitScript (SC2317) https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
- Use correct bracket notation for ssh-keygen -R with non-standard port - Fix "You password" -> "Your password" grammar https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
Quoting values like :0,password=on and file=...,index=0,media=cdrom prevents shellcheck SC2054 false positives while preserving correct QEMU argument passing. Add SC2034 disable for intentional VERSION_SCRIPT and SCRIPT_TYPE metadata variables. https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
Three lint jobs run on push/PR to main: - ShellCheck static analysis (severity: warning) - Bash syntax validation (bash -n) - Codespell typo detection https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
Reflects audit fixes: arrays for QEMU args, shellcheck compliance, GitHub Actions CI, and multiple security/correctness improvements. https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
- Add dialog to requirements - Document -dns flag in CLI options and features - Add menu item 8 (disk selection) - Replace non-existent -run example with -dns example - Mention HTTPS downloads and SHA256 verification https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.