fix: harden IPv4 address string handling#49
Open
hlolli wants to merge 1 commit into
Open
Conversation
Replace the IPv4 logging paths in the interface code with bounded inet_ntop conversions instead of copying inet_ntoa output with strncpy. The previous code depended on implicit null termination, which is exactly the kind of edge case static analysis tools flag because it can turn a harmless log line into undefined behavior if the buffer contents are ever reused as a C string. This keeps the behavior the same for normal traffic, but makes the code explicit about buffer sizing and string termination. It also centralizes the conversion in a tiny helper so future address logging in this file can reuse the safer path instead of open-coding it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the IPv4 logging paths in the interface code with bounded inet_ntop conversions instead of copying inet_ntoa output with strncpy. The previous code depended on implicit null termination, which is exactly the kind of edge case static analysis tools flag because it can turn a harmless log line into undefined behavior if the buffer contents are ever reused as a C string.
This keeps the behavior the same for normal traffic, but makes the code explicit about buffer sizing and string termination. It also centralizes the conversion in a tiny helper so future address logging in this file can reuse the safer path instead of open-coding it again.