Skip to content

Fix PR review comments: remove duplicates, fix dates, clean unused code, fix Redis SCAN bug #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: claude/resolve-pr9-launch-01Qoi7se3KmWkugvd634NYhZ
Choose a base branch
from
Draft

Fix PR review comments: remove duplicates, fix dates, clean unused code, fix Redis SCAN bug #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dee794e
Initial plan
Copilot Nov 27, 2025
1b3ad90
fix: address all PR review comments - remove duplicates, fix dates, r…
Copilot Nov 27, 2025
0486f12
fix(redis): make existsPattern iterate through all SCAN results
Copilot Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PR9_FINAL_REPORT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# PR #9 Final Production Report

**Date:** 2024-11-17
**Date:** 2025-11-17
**Branch:** `claude/resolve-pr9-launch-01Qoi7se3KmWkugvd634NYhZ`
**Status:** ✅ **100% COMPLETE - PRODUCTION READY** 🎉

Expand Down
2 changes: 1 addition & 1 deletion PR9_IMPROVEMENT_ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**Status:** Changes Requested
**Created:** 2025-11-16
**Priority:** CRITICAL - App Store Launch Deadline: Nov 18, 11:59 PM CST
**Priority:** CRITICAL - App Store Launch Deadline: 2025-11-18, 11:59 PM CST
**Branch:** `claude/resolve-pr9-launch-01Qoi7se3KmWkugvd634NYhZ`

---
Expand Down
2 changes: 1 addition & 1 deletion PR9_PROGRESS_REPORT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# PR #9 Implementation Progress Report

**Date:** 2024-11-16
**Date:** 2025-11-16
**Branch:** `claude/resolve-pr9-launch-01Qoi7se3KmWkugvd634NYhZ`
**Session:** Implementation Phase 2
**Status:** ✅ 83% Complete (5/6 CRITICAL+MAJOR issues)
Expand Down
2 changes: 1 addition & 1 deletion PR9_QUICK_REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# PR #9 Quick Reference Guide

**Last Updated:** 2025-11-16
**Deadline:** Nov 18, 11:59 PM CST (App Store Launch)
**Deadline:** 2025-11-18, 11:59 PM CST (App Store Launch)
**Branch:** `claude/resolve-pr9-launch-01Qoi7se3KmWkugvd634NYhZ`

---
Expand Down
4 changes: 1 addition & 3 deletions backend/services/game-service/src/__tests__/gamification-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ import {
calculatePointsDetailed,
calculatePointsWithDecay,
GamificationService,
DEFAULT_SCORING_CONFIG,
ChallengeResult,
ScoringResult
ChallengeResult
} from '../services/gamification-service';

describe('GamificationService - Point Calculation', () => {
Expand Down
2 changes: 1 addition & 1 deletion backend/services/mcp-server/src/__tests__/base-tool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* @see Issue #6: MAJOR - MCP Server Sensitive Data Logging
*/

import { BaseMCPTool, ExampleTool, ToolExecutionResult } from '../tools/base-tool';
import { BaseMCPTool, ExampleTool } from '../tools/base-tool';

// Test implementation of BaseMCPTool
class TestTool extends BaseMCPTool<{ message: string }, { result: string }> {
Expand Down
1 change: 0 additions & 1 deletion backend/services/mcp-server/src/__tests__/mcp-logging.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
sanitizeMCPToolArgs,
sanitizeMCPResponse,
MCP_SENSITIVE_FIELDS,
MCP_SANITIZATION_CONFIG,
mcpLoggingMiddleware,
createLoggingContext,
logToolInvocation,
Expand Down
Loading