Fix CVE-2025-66414 and reduce CLI method complexity - #50
Merged
Conversation
- Update @modelcontextprotocol/sdk from 1.20.1 to 1.26.0 (fixes CVE-2025-66414) - Extract helper functions to reduce complexity in hive-mind spawn command - Create hive-mind-helpers.ts with GOAP, task execution, and result rendering functions - Create doctor-helpers.ts with health check functions - Refactor doctor command to use extracted helper functions - Reduce method complexity from 364+ lines to more maintainable chunks Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
- Restore original auth check logic using negative test for "not logged in" - Change require() to dynamic import() for ES module consistency - Ensure completion message is always shown before YAML output - Make renderExecutionSummary async to support dynamic import Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
- Add ExecutionResultData interface for type safety - Add comprehensive JSDoc comments with @param and @returns tags - Remove unused checkMcpProfile function - Update function signatures to use proper types instead of any Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add MCP workflows and growth automation docs
Fix CVE-2025-66414 and reduce CLI method complexity
Feb 13, 2026
clduab11
marked this pull request as ready for review
February 13, 2026 03:35
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeFactor flagged vulnerable
@modelcontextprotocol/sdkdependency and three complex methods insrc/cli/index.tsexceeding maintainability thresholds.Changes
Security
@modelcontextprotocol/sdk1.20.1 → 1.26.0 (fixes CVE-2025-66414)Refactoring
Extract helper functions into dedicated modules to reduce method complexity:
src/cli/hive-mind-helpers.ts- orchestration lifecycleexecuteGoapWorkflow()- GOAP executionexecuteTaskWithConsensus()- task dispatch with timeout/votingcollectExecutionResults()- aggregate system metricsrenderExecutionSummary()- formatted outputsetupWorkflowEventHandlers()- event subscription managementsrc/cli/doctor-helpers.ts- health checkscheckCliBuildArtifact(),checkCliExecution(),checkCodexAuth()- validationrenderHealthCheckResults()- diagnostic outputType safety
ExecutionResultDatainterface replacinganytypesExample
Before (364-line monolithic handler):
After (28-line orchestrator):
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.