fix: wire Submit Feedback button on dashboard to /plans - #76
Open
clates wants to merge 1 commit into
Open
Conversation
The button was rendered but had no onClick handler, so clicking it did
nothing. Added useRouter and router.push('/plans') so clicking the button
takes the user to the Plans page where the full feedback flow lives.
Also adds a Playwright E2E test that seeds a student with a pending
packet, navigates to /dashboard with networkidle (needed because the
dashboard loads students then packets in two sequential async fetches),
verifies the Submit Feedback button is visible, clicks it, and asserts
navigation to /plans.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onClickhandler — clicking it did nothingdashboard/page.tsxrendered the button with no action attacheduseRouterimport andonClick={() => router.push('/plans')}so the button navigates to the Plans page where the full feedback flow (plan detail modal → feedback modal) livesTest plan
Dashboard — Submit Feedback button › Submit Feedback button on dashboard navigates to /plans/dashboardwithwaitUntil: 'networkidle'(required because dashboard has a two-stage async load: students first, then packets)/plans🤖 Generated with Claude Code