Hi! I cleaned up your code for you!#1

Open

GunioRobot wants to merge 5980 commits into

clarabstract:masterfrom

GunioRobot:clean

This pull request is big! We're only showing the most recent 250 commits

Commits on Feb 1, 2010

Update the Gemfile and CI build
Carl Lerche
committed
Merge branch 'master' of git://github.com/rails/rails
mikel
committed

Commits on Feb 2, 2010

Fixed --dev flag for new bundler
mikel
committed
Resolve view paths correctly on CygWin

rubys
authored and
mikel
committed
Make rdoc match current API

rubys
authored and
mikel
committed
Hide '/rails/info/properties' from 'rake routes' [#3793 state:resolved]

sikachu
authored and
lifo
committed
Updating USAGE information for Mailer generator [#3801 status:resolved]

Kieran Pilkington
authored and
josevalim
committed
fixed migration logger bug [#3434 status:resolved]

probablycorey
authored and
josevalim
committed
Add test case for unable to run migration if ActiveRecord::Base.logger is nil (#3434)

sikachu
authored and
josevalim
committed
Modify the behavior of `radio_button_tag` to use `sanitize_to_id` for consistency [#1792 status:resolved]

sikachu
authored and
josevalim
committed
Change Rails::Generators::Migration protected instance methods to class methods. [#3820 status:resolved]

szimek
authored and
josevalim
committed
Ensure that attr_reader methods in generators are protected.
josevalim
committed
Get rid of deprecation warnings on config/environments/*
josevalim
committed
Configuration values should be on AV::Base.
josevalim
committed
Routing Mapper with % interpolation on Ruby 1.9.1 fixed [#3837 status:resolved]

Santiago Pastorino and José Ignacio Costa
authored and
josevalim
committed
Revert "failing tests in multibyte_chars_test.rb fixed". The bug is in Ruby 1.9.1 p376, not in AS test suite.
josevalim
committed
Fix invocation of system commands in ci script

thewoolleyman
authored and
Carl Lerche
committed
Use bundler 0.9.0.pre4 when running CI
Carl Lerche
committed
Removed all the default commands in script/* and replaced them with script/rails and a rails command that'll act the same when run from within the app [DHH]
David Heinemeier Hansson
committed
Remove the generated gemfile in railties tests since the rails gemfile is used.
Carl Lerche
committed
Boot path has already been required, dont need it again
David Heinemeier Hansson
committed
Add a reminder that you should use "rails" not "script/rails" when running normally
David Heinemeier Hansson
committed

Commits on Feb 3, 2010

Commits on Feb 4, 2010

Removing submodule hacks

Yehuda Katz
authored and
Yehuda Katz
committed
Update rails to use the latest bundler
Carl Lerche
committed
Adding guard to make sure test database declarations exist before trying to auto create
mikel
committed
-v and --version params now work on rails script in or our of an app
mikel
committed
removing , from ,= statement in WrappedDatabaseException constructor

subbarao
authored and
jeremy
committed
Merge remote branch 'mikel/master'
jeremy
committed
Copy over latest release notes from docrails
David Heinemeier Hansson
committed
Simplify description
David Heinemeier Hansson
committed
Move to 3.0.0.beta
David Heinemeier Hansson
committed
Merge
David Heinemeier Hansson
committed
remove arel directory, breaks 'git submodule init', which breaks ci builds

thewoolleyman
authored and
Yehuda Katz
committed
Homogenize gemspecs and remove the deprecated autorequire
David Heinemeier Hansson
committed
Autorequire bundled libraries by default
jeremy
committed
Bump bundler dep to 0.9.1.pre1
jeremy
committed
Use a normal gem source url instead of a magic symbol
jeremy
committed
Remove instrument! and require thread from AS::Notifications.
josevalim
committed
Merge branch 'master' of gitproxy:rails/rails
josevalim
committed
Update Gemfile to use latest bundler config.
josevalim
committed
Automatically require rubygems when --dev flag is given.
josevalim
committed
require 'action_controller' added on a test that uses it

Santiago Pastorino and José Ignacio Costa
authored and
josevalim
committed
Remove duplicated version check.
josevalim
committed
Make RAILS_* give deprecation warning just once
lifo
committed
Updated the database.yml file generated for ibm_db to the latest version of DB2 and the gem.

acangiano
authored and
jeremy
committed
Move framework requires and Bundler.require from boot.rb to app.rb. Cut down the list of railtie choices to those that make sense.
jeremy
committed
Rationalize railtie dependencies: AC uses AV; AR uses AMo; and Rails always uses AS.
jeremy
committed
Use the correct environment.rb path
jeremy
committed
Fix broken autorequires
jeremy
committed
Rails script commands load the application rather than just boot
jeremy
committed
Revert "Rails script commands load the application rather than just boot"
jeremy
committed
server command loads the application
jeremy
committed
Depend on bundler >= 0.9.1
jeremy
committed
Autorequire default libs and those in groups named after the current Rails environment
jeremy
committed
Bump to bundler 0.9.2
jeremy
committed
Link to main Arel repository

brynary
authored and
jeremy
committed
Ensure javascripts are pulled in so UJS can hook the Delete link
jeremy
committed
Expose CSRF tag for UJS adapters
jeremy
committed
fix rubygems/bundler install in ci build script

thewoolleyman
authored and
jeremy
committed
Expose CSRF param name also
jeremy
committed

Commits on Feb 5, 2010

HTML-escape csrf meta contents
jeremy
committed
Update prototype-ujs for data-confirm
jeremy
committed
Revert dumb test
jeremy
committed
Add prototype ujs handler for data-method
jeremy
committed
Test that csrf meta content is html-escaped, too
jeremy
committed
Release using gemcutter gem:push tasks
jeremy
committed
Need gemcutter here too
David Heinemeier Hansson
committed
No sense bundling sense it's not available in Rakefile. Also, actually require.
jeremy
committed
Fix task defines
jeremy
committed
Kill default require_path
jeremy
committed
Add the dummy rails3b gemspec that pulls in non-prerelease deps
jeremy
committed
Submarine the rake-gemcutter dep in Rakefiles
jeremy
committed
install ActionController::UrlFor before environment is parsed, to provide ActionMailer#default_url_options=

Paul Rosania
authored and
jeremy
committed
Revert "Link to main Arel repository"
jeremy
committed
Bump arel dep
jeremy
committed
Bump git versions to 3.0.0.beta1 since we've released
jeremy
committed
Add yajl-ruby as a JSON parsing backend

brianmario
authored and
jeremy
committed
Automatically prefer Yajl or JSON backend over Yaml, if available
jeremy
committed
Make UrlWriter includable in a Module
jeremy
committed
Fixed html_safe test cases which weren't testing correctly

Santiago Pastorino and José Ignacio Costa
authored and
jeremy
committed
Making SafeBuffer << an alias for concat method

spastorino
authored and
jeremy
committed
More html_safe strings now use the safe_concat method

Santiago Pastorino and José Ignacio Costa
authored and
jeremy
committed

Commits on Feb 6, 2010

test_validates_acceptance_of_as_database_column fixed

spastorino
authored and
jeremy
committed
method_missing errors on activeresource tests, mocha is not required there

spastorino
authored and
jeremy
committed
CI: add missing isolated tests
jeremy
committed
CI: show bundled gems
jeremy
committed
New style for path references
David Heinemeier Hansson
committed
Path approach shouldnt specify version
David Heinemeier Hansson
committed
Simplify conditions for --dev and --edge
David Heinemeier Hansson
committed
Not a fan of the double ##
David Heinemeier Hansson
committed
Cleanup comments
David Heinemeier Hansson
committed
Lookup the status code and rework the Completed line a bit
David Heinemeier Hansson
committed
Fixes test fail
Yehuda Katz
committed
Updates subscriber test for new output
Yehuda Katz
committed
Routes should not swallow all NameErrors [#3862 status:resolved].
josevalim
committed
Add a test which ensures namespaced roots.
josevalim
committed
Fix 'rails server -h' double help banner. Correct its usage line. [#3874 status:resolved]

henrik
authored and
josevalim
committed
Fix tiny version number from '3.0.0beta' to '3.0.0.beta1', so 'rake install' will be run correctly [#3879 status:resolved]

sikachu
authored and
josevalim
committed
Add config.generators.templates to provide alternative paths for template lookup.
josevalim
committed
removes Kernel#daemonize, which is no longer used
fxn
committed
rack debugger needs active_support/core_ext/kernel/requires for require_library_or_gem
fxn
committed
fix usage examples and more to use new invocations

romdi
authored and
Carl Lerche
committed
remove trailing whitespace

romdi
authored and
Carl Lerche
committed
Merge remote branch 'fxn/master'
jeremy
committed
Silenced "SHOW FIELDS" and "SET SQL_AUTO_IS_NULL=0" statements from the MySQL driver to improve log signal to noise ration in development [DHH]
David Heinemeier Hansson
committed
Merge branch 'master' of github.com:rails/rails
David Heinemeier Hansson
committed

Commits on Feb 7, 2010

CI: set env after sudo
jeremy
committed
CI: sudo unnecessary. Bump bundler dep to 0.9.3.
jeremy
committed
remove all sudo references from CI build script

thewoolleyman
authored and
jeremy
committed
Fixing actionmailer tests for CI

mikel
authored and
Yehuda Katz
committed
Added newline to appended gem config in Gemfile

dkubb
authored and
Yehuda Katz
committed
Fix nested attributes with specified collection.
josevalim
committed
Add backtrace cleaner on test unit railtie.
josevalim
committed
fix ambiguous example for new invocation method

romdi
authored and
josevalim
committed
Check if Test::Unit is defined before adding backtrace filter.
josevalim
committed
Fix doc typo and update fast_xs URL. Thanks to Dmitrii Golub.
jeremy
committed
Fix pluralization for numbers formatted like '1.00'

gabrielmansour
authored and
jeremy
committed
removes Module#included_in_classes, which is no longer used
fxn
committed
removes Module#as_load_path, which is no longer used
fxn
committed

Commits on Feb 8, 2010

Commits on Feb 9, 2010

rails runner loads environment after parsing command-line options
jeremy
committed

Commits on Feb 10, 2010

Suggest Mongrel and Capistrano in the default bundle
David Heinemeier Hansson
committed
Its not a deprecation if you actually just ignore the call
David Heinemeier Hansson
committed
Reinstate Object.subclasses_of and Class#descendents for plugin compat.
jeremy
committed
Reinstate object/extending require too for Object.subclasses_of
jeremy
committed
Debrittlize tests somewhat - fix for CI build

mikel
authored and
josevalim
committed
Add missing -h/--help flag to several rails command [#3909 status:resolved]

sikachu
authored and
josevalim
committed
Add default values to output of 'rails server -h', hardcoded as Rack::Server did since options doesn't have any data at the time of parsing arguments [#3910 status:resolved]

sikachu
authored and
josevalim
committed
Fix server environment [#3877 status:resolved]

sniemela
authored and
josevalim
committed
Fixes unescaped version passthrough of generator 'gem' command. [#3901 status:resolved]

Michael Bleigh
authored and
josevalim
committed
Fix a couple failing tests.
josevalim
committed
fixes doc generation

fxn
authored and
jeremy
committed
Don't rely on @message in Error classes being available for use

Yehuda Katz
authored and
Yehuda Katz
committed
No need to emulate default Ruby behavior in initialize

Yehuda Katz
authored and
Yehuda Katz
committed
Fix a JSON ordering issue

Yehuda Katz
authored and
Yehuda Katz
committed
Since require_dependency cannot be cleared, remove the dependencies

Yehuda Katz
authored and
Yehuda Katz
committed

Commits on Feb 11, 2010

Commits on Feb 13, 2010

Safely concat the ending tag to simple_format or it will be escaped
David Heinemeier Hansson
committed
simple_format returns a safe buffer escaping unsafe input [Santiago Pastorino]
David Heinemeier Hansson
committed

Commits on Feb 14, 2010

Simplify dependencies.rb some. Remove alias of Kernel::Foo to Object::Foo as it was not used and breaks Ruby semantics.

Yehuda Katz
authored and
Yehuda Katz
committed
adds a few missing requires in AS object.rb and module.rb

fxn
authored and
Yehuda Katz
committed
name.blank? -> anonymous? in a few places

fxn
authored and
Yehuda Katz
committed
Missing require

Yehuda Katz
authored and
Yehuda Katz
committed
Save off Module's const_missing, not Class'

Yehuda Katz
authored and
Yehuda Katz
committed
require Strings, not Symbols

Yehuda Katz
authored and
Yehuda Katz
committed
content_tag should escape its input

nono
authored and
Yehuda Katz
committed
html_escape mail_to when encode javascript and not hex

Santiago Pastorino and José Ignacio Costa
authored and
Yehuda Katz
committed
Explicit html_escape removed when not needed

Santiago Pastorino and José Ignacio Costa
authored and
Yehuda Katz
committed
Right.

Yehuda Katz
authored and
Yehuda Katz
committed
name.blank? -> anonymous?

fxn
authored and
Yehuda Katz
committed

Commits on Feb 15, 2010

Commits on Feb 16, 2010

Update AP to start locking down a public API. This work is parallel to some docs I'm working on.

Yehuda Katz
authored and
Yehuda Katz
committed
Rename Rails::Subscriber to Rails::LogSubscriber

sikachu
authored and
josevalim
committed
Subscriber should not explode if a non namespaced instrumentation is given.
josevalim
committed
Do not swallow controller loading errors unless required.
josevalim
committed
Should allow symbols in :only and :except in routes.
josevalim
committed
AD::TestProcess relies on request.flash, so let's load it.
josevalim
committed
Ensure render :text => resource first tries to invoke :to_text on it
josevalim
committed
Clear the attribute after done

Yehuda Katz
authored and
Yehuda Katz
committed
Make Railties tests green again.
josevalim
committed
Show deprecation message for rails/init.rb in plugins.
josevalim
committed
Invalid namespace on app generation raises an error

fizx
authored and
josevalim
committed
Merge master.
josevalim
committed

Commits on Feb 17, 2010

Commits on Feb 18, 2010

Fix called_from under Windows so engines works properly

aaronchi
authored and
josevalim
committed
Ensure config.after_initializer is executed before building the middleware stack.
josevalim
committed
Use FileUtils.mv instead of rename to copy in case of cross-device links
jeremy
committed
Update Renderer

Yehuda Katz
authored and
Yehuda Katz
committed
Don't constantize possible module names when looking for new constants unless they exist

Yehuda Katz
authored and
Yehuda Katz
committed

Commits on Feb 19, 2010

Avoid calling triggering const_missing if const_missing is private when doing constantize
Carl Lerche
committed
i18n translate with arrays issue solved

spastorino
authored and
Yehuda Katz
committed
Git fail

Yehuda Katz
authored and
Yehuda Katz
committed
ruby 1.9 array.to_s returns a string representing an escaped array

spastorino
authored and
Yehuda Katz
committed
Revert behavior from a5684dfa3c16472bfa5d5d861ba78cb6dbadcb59 and ensure after_initializer is executed after to_prepare callbacks.
josevalim
committed
Allow to choose the template path and template name used in implicit rendering with ActionMailer.
josevalim
committed
Reinstate pending tests that were supposed to be fixed before the
josh
committed
Fix a problem where nil was appearing in the list

Yehuda Katz
authored and
Yehuda Katz
committed
Fix test ordering bug related to introducing masked Name class

Yehuda Katz
authored and
Yehuda Katz
committed
warning: instance variable @_const_missing not initialized fixed

spastorino
authored and
Yehuda Katz
committed
Remove empty line and trailing hash, breaks documentation generation

dbussink
authored and
Yehuda Katz
committed
require publicize_conversion_method to ensure to_date and to_datetime became public before redefining them (avoid warnings)

spastorino
authored and
Yehuda Katz
committed
i18n translate with arrays issue solved

spastorino
authored and
Yehuda Katz
committed
Revert "i18n translate with arrays issue solved"

Yehuda Katz
authored and
Yehuda Katz
committed

Commits on Feb 20, 2010

Commits on Feb 21, 2010

Commits on Feb 22, 2010

Fix AMo isolated tests.
josevalim
committed
don't set @expected.date in generated mailer test

dchelimsky
authored and
josevalim
committed
Adding options to register observers and interceptors through ActionMailer::Base.register_observer and ActionMailer::Base.register_interceptor. These hook into Mail.register_interceptor and Mail.r…

mikel
authored and
josevalim
committed
Include missing modules.
josevalim
committed
Rename erubis_implementation to erb_implementation.
josevalim
committed
avoid active not initialized warning

spastorino
authored and
Yehuda Katz
committed
avoid @transaction_joinable not initialized warning

spastorino
authored and
Yehuda Katz
committed
avoid @lock_value not initialized warning

spastorino
authored and
Yehuda Katz
committed

Commits on Feb 23, 2010

Fix streaming by having it create a File object, which can be handled by Rack servers as appropriate
Carlhuda
committed

Commits on Feb 24, 2010

Make AD::Response correctly handle bodies that respond_to?(:to_path) as per the Rack spec
Carlhuda
committed
Makes send_file work again by deferring to Rack::Sendfile.
Carlhuda
committed
Revert "Fix test load paths for those not using bundler"
Carlhuda
committed
Woops, forgot to actually add active_support/core_ext/file/path.rb
Carlhuda
committed
Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. Closes #8994

Yehuda Katz
authored and
Yehuda Katz
committed

Commits on Oct 28, 2011

Remove whitespace [Gun.io WhitespaceBot]
Gun.io Whitespace Robot
committed