Publish v1.1.3 fix typings - #44
Merged
Merged
Conversation
- Renamed source entry files to avoid shadowing npm packages: - src/react.ts -> src/react-integration.ts - src/preact.ts -> src/preact-integration.ts - src/remix.ts -> src/remix-integration.ts - Fixed TypeScript resolving 'react'/'preact' imports to our files instead of actual packages - All tests pass (351/351) - Type-check passes without errors This fixes CI failures where test files importing from 'react' or 'preact' were incorrectly resolved to our integration files.
BREAKING CHANGE from v1.1.0-1.1.2: Those versions had broken type definitions. Changes: - Switched from vite-plugin-dts to using tsc directly for type declarations - Added tsconfig.build.json for generating declarations - Added typesVersions to package.json for backward compatibility - Updated exports to use correct type definition file names The key insight was that vite-plugin-dts was generating incorrect relative paths in .d.ts files (e.g., '../store' instead of './store'). Using tsc directly with a dedicated tsconfig.build.json generates correct paths. Tested with: - moduleResolution: 'node' ✅ - moduleResolution: 'bundler' ✅ - All 351 tests pass ✅ - type-check passes ✅
clamstew
force-pushed
the
publish-v1.1.3-fix-typings
branch
from
November 28, 2025 04:24
fa5ddf6 to
00c0881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
AI Optimization Checklist
pnpm run ai:syncto verify AI-optimized files are in syncHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: