Prefer reuse of recently used uploader threads to improve connection reuse - #61
Open
UCIS wants to merge 2 commits into
Open
Prefer reuse of recently used uploader threads to improve connection reuse#61UCIS wants to merge 2 commits into
UCIS wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer reuse of recently used uploader threads over the semi-random selection that occurs with idle wait loop to improve connection reuse. For miners on a fast connection, this should reduce the number of idle keepalive connections, saving resources on the miner and pool. The configured number of uploaders will behave like an upper limit rather than an absolute number. An added bonus might be that the more aggressive reuse of connections could reduce the number of reconnections and slow-start situations because idle connections keep timing out.