Add volume number for monographs without editor#13
Open
adam3smith wants to merge 1 commit into
Open
Conversation
The current conditionals don't kick in for books with no secondary creators, we need to repeat the call to the capitalized volume macro
adam3smith
requested review from
adunning and
Copilot
and removed request for
Copilot
May 14, 2026 13:09
There was a problem hiding this comment.
Pull request overview
This PR adjusts MLA CSL rendering so authored monographs without secondary creators can still emit a capitalized volume label.
Changes:
- Adds a fallback in
container1-numberto renderlabel-volume-capitalizedwhen an authored item has no matched contributor variables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+750
to
+752
| <else> | ||
| <text macro="label-volume-capitalized"/> | ||
| </else> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current conditionals don't kick in for books with no secondary creators, we need to repeat the call to the capitalized volume macro
cc @adunning if you have a minute to look at this? Though I'm pretty sure I'm right about this.