fix(webhooks): require HMAC verification before order mutations - #20
Open
SashaMIT wants to merge 1 commit into
Open
fix(webhooks): require HMAC verification before order mutations#20SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Payment webhook HMAC verification was commented out while the handler still uses the Supabase service-role client to mark orders Paid / Refunded / Canceled. Fail closed when WEBHOOK_SECRET is unset, verify x-scp-signature with timing-safe compare, and parse the verified body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/webhooks/paymentsdrives order lifecycle (Paid/Refunded/Canceled/ …) through the Supabase service-role client, but HMAC verification was left commented out:That is fail-open: any caller who can reach the endpoint and supply a payment
saltcan forge lifecycle transitions withoutWEBHOOK_SECRET. README already listsWEBHOOK_SECRETas required setup and documents SCP signing.This PR:
503whenWEBHOOK_SECRETis unset (fail closed)x-scp-signatureas HMAC-SHA256 over the raw body with length-checkedtimingSafeEqualOperator routes that write order status without SCP remain unchanged.
Test plan
WEBHOOK_SECRETunset →503x-scp-signature→401npm run linton touched fileMade with Cursor