fix: validate checkout token amounts - #18
Open
worlldz wants to merge 1 commit into
Open
Conversation
worlldz
marked this pull request as ready for review
August 7, 2026 10:23
worlldz
force-pushed
the
fix/validate-checkout-amount
branch
from
August 7, 2026 10:37
af02fdd to
a46bd37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
400response for unsupported formats instead of lettingparseUnitsthrow or round the valueWhy
POST /api/checkout/intentfirst coerced the amount withNumber()and then passed the original string toparseUnits(). Values such as1e3passed the numeric check but causedparseUnits()to throw, producing an unhandled server error. Values beyond the token's six-decimal precision could also be rounded instead of rejected.The new parser accepts only positive plain-decimal values that can be represented exactly by the token.
Testing
npm testnpx tsc --noEmitnpm run lintnpm run build