Fix package description to match actual lending token flow - #30
Open
leonschh wants to merge 1 commit into
Open
Conversation
The `package.json` description incorrectly says the demo uses **USDC as collateral and ARCT as the borrowed token**. The deployment configuration uses the opposite flow: - `cirBTC` is passed as the collateral token. - The deployed mock `USDC` is passed as the lending/loan token. - The deployment summary explicitly describes the flow as **deposit cirBTC as collateral and borrow USDC**. Update the package description to match the actual deployment configuration. This is a metadata-only correction and does not change app behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
package.jsondescription incorrectly says the demo uses USDC as collateral and ARCT as the borrowed token.The deployment configuration uses the opposite flow:
cirBTCis passed as the collateral token.USDCis passed as the lending/loan token.This is also consistent with the token parameters in
contracts/LendingBorrowing.sol, where the first constructor argument is the collateral token and the second is the lending token.Update the package description to match the actual deployment configuration.
This is a metadata-only correction and does not change app behavior.