ONP-4123: Address post-merge review comments on MRO benchmarks page - #10772
Conversation
- Fix semicolon to period in intro paragraph (rosieyohannan) - Expand "jobs/min" to "jobs per minute" (rosieyohannan) - Split em-dash sentence and move "Both resource classes..." before table (rosieyohannan) - Move p50/p90/p99 definitions under Increasing-load results as a definition list (rosieyohannan) - Convert resource class spec lines to bullet lists across all four subsections (rosieyohannan)
circleci-factory-bot
left a comment
There was a problem hiding this comment.
FAIL 🔴 author-membership ⚙️ author not in allow-list
soulchips is not in the allow-listed users; allowed: rosieyohannan
PASS 🟢 impact-matches-intent ✨ Editorial docs change matches stated intent
Editorial-only edits to machine-runner-orchestrator-performance-benchmarks.adoc (punctuation, "jobs/min"→"jobs per minute", sentence split/reorder, inline→bullet/definition lists). No exported entity, config value, or customer-gated surface changes; stated intent matches the diff and no consumers break.
SKIP ⚪ 6 skipped check(s)
SKIP ⚪ api-auth-and-design ⚙️ no V3/auth signals in diff
no V3 or auth signals in 1 changed file(s): docs/guides/modules/execution-runner/pages/machine-runner-orchestrator-performance-benchmarks.adoc
SKIP ⚪ agents-md-respect ✨ Style fixes comply with AGENTS.md punctuation rules
The diff replaces semicolons and em-dashes with periods/colons/bullet lists, expands "jobs/min" to "jobs per minute," and reformats percentile definitions as a definition list — all directly aligned with AGENTS.md rules (avoid semicolons, avoid dashes to split sentences or separate item/description, capitalize and punctuate list items). No applicable instruction-file rule is violated.
SKIP ⚪ git-hygiene ⚙️ git history is clean
no merge commits, and no problems with the commit messages
SKIP ⚪ go-best-practices ⚙️ no Go changes to review
no reviewable Go changes among 1 changed file(s)
ignoring 1 non-Go files: docs/guides/modules/execution-runner/pages/machine-runner-orchestrator-performance-benchmarks.adoc
SKIP ⚪ reduces-risk ⚙️ non-test files changed
change touches 1 non-test file(s): docs/guides/modules/execution-runner/pages/machine-runner-orchestrator-performance-benchmarks.adoc
SKIP ⚪ server-compat ⚙️ no new required config keys
no new env.MustGet calls added in this PR
🤖 factory-bot · codeowner mode · reviewed @ 2026-09-22T16:45:54Z · re-request a review to re-run
[trace:63718f7] [bot 7479d8b] [config dc281d7] [target cc5d40a]
Summary
Follow-up to #10736. Addresses rosieyohannan's review, which was submitted after the PR merged.
; all→. All)jobs/mintojobs per minutein test setupResource class: ... — VM, maxReplicas=N) to bullet lists, applied consistently to all four subsections (large/small increasing-load, large/small burst)Test plan