Skip to content

Clarify what an org admin is, using partial - #10478

Open
rosieyohannan wants to merge 1 commit into
mainfrom
DOC-146-org-admin-prerequ
Open

rosieyohannan wants to merge 1 commit into
mainfrom
DOC-146-org-admin-prerequ

Conversation

@rosieyohannan

Copy link
Copy Markdown
Contributor

Use our prerequisites partial that describes what an org administrator is where appropriate

@rosieyohannan
rosieyohannan requested review from a team as code owners June 16, 2026 12:47
@linear-code

linear-code Bot commented Jun 16, 2026

Copy link
Copy Markdown

DOC-146

@rosieyohannan rosieyohannan changed the title Clarify what an org admin is using partial Clarify what an org admin is, using partial Jun 16, 2026

@circleci-factory-bot circleci-factory-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAIL 🔴 agents-md-respect ✨ "Select on the...toggle" is ungrammatical (l.27)

In prevent-unregistered-users-from-spending-credits.adoc:27, "Click on the Prevent unregistered user spend toggle" was changed to "Select on the Prevent unregistered user spend toggle" — "Select on" is ungrammatical and violates the style guide's requirement for simple, direct, clear language. Fix: change to "Select the Prevent unregistered user spend toggle to switch it "On"." (drop the "on").

WARN 🟡 git-hygiene ⚙️ lone commit has a one-line message

the branch's only commit 0c60e7c "clarify org admin using partial" has no message body. explain why the change is needed in a body below the subject line so reviewers and future readers get the reasoning.

PASS 🟢 impact-matches-intent ✨ Doc partial swap matches intent; minor typo l.28

Documentation-only change: inline org-admin prerequisites are replaced by the existing ROOT:partial$prerequisites/organization-admin.adoc partial, which is already used elsewhere in-repo — actual impact matches the stated intent (clarify org admin using partial). Minor non-blocking nit: in prevent-unregistered-users-from-spending-credits.adoc:28 the edit "Click on" → "Select on the toggle" reads as a grammatical typo unrelated to the stated intent; consider "Toggle the ... switch" for consistency with other pages.

SKIP ⚪ 5 skipped check(s)
SKIP ⚪ api-auth-and-design ⚙️ no V3/auth signals in diff

no V3 or auth signals in 5 changed file(s): docs/guides/modules/deploy/pages/configure-deploy-markers.adoc, docs/guides/modules/getting-started/pages/invite-your-team.adoc, docs/guides/modules/plans-pricing/pages/prevent-unregistered-users-from-spending-credits.adoc, docs/guides/modules/security/pages/delete-organizations-and-projects.adoc, docs/guides/modules/toolkit/pages/enable-ai-powered-features.adoc

SKIP ⚪ author-membership ⚙️ author is allow-listed

rosieyohannan is an allow-listed author

SKIP ⚪ go-best-practices ⚙️ no Go changes to review

no reviewable Go changes among 5 changed file(s)
ignoring 5 non-Go files: docs/guides/modules/deploy/pages/configure-deploy-markers.adoc, docs/guides/modules/getting-started/pages/invite-your-team.adoc, docs/guides/modules/plans-pricing/pages/prevent-unregistered-users-from-spending-credits.adoc, docs/guides/modules/security/pages/delete-organizations-and-projects.adoc, docs/guides/modules/toolkit/pages/enable-ai-powered-features.adoc

SKIP ⚪ reduces-risk ⚙️ non-test files changed

change touches 5 non-test file(s): docs/guides/modules/deploy/pages/configure-deploy-markers.adoc, docs/guides/modules/getting-started/pages/invite-your-team.adoc, docs/guides/modules/plans-pricing/pages/prevent-unregistered-users-from-spending-credits.adoc, docs/guides/modules/security/pages/delete-organizations-and-projects.adoc, docs/guides/modules/toolkit/pages/enable-ai-powered-features.adoc

SKIP ⚪ server-compat ⚙️ no new required config keys

no new env.MustGet calls added in this PR

🤖 factory-bot · codeowner mode · reviewed @ 2026-09-23T13:59:15Z · re-request a review to re-run
[trace:885f165] [bot 3e95a64] [config 0e6618e] [target 0c60e7c]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants